Update the rcljava parameter APIs (port osrf/ros2_java#1) #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation was missing BoolArray, IntegerArray, DoubleArray, and StringArray. Doing this required a change to the constructor for ParameterVariant, since List is a Generic and we can't have multiple constructors with the same signature. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
It gets rid of a warning when starting the tests that looks like: log4j:WARN No appenders could be found for logger (org.ros2.rcljava.common.JNIUtils). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
It doesn't need to change, so it can just be a class variable. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
That way we have the information available when other methods want to retrieve it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
The parameters are stored in a HashMap of name -> parameter, but we were unnecessarily iterating over the HashMap to find things. Instead, look up the items directly in the map which should be much faster. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Whether to allow undeclared parameters is a decision that is made during Node creation. Plumb through the necessary option so that the user can choose to allow undeclared parameters when they create the node. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This one just takes a name and sets the type to NOT_SET. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This interface is what users will have to implement in order to have their callback called when parameters are set. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
The parameter API was significantly updated during the Dashing release cycle. Update the API in rcljava to provide similar functionality and make the API look a lot more like rclcpp and rclpy. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
ivanpauno
changed the title
https://github.com/osrf/ros2_java/pull/1)
ivanpauno
changed the title
https://github.com/osrf/ros2_java/pull/1)https://github.com/osrf/ros2_java/pull/1_)
ivanpauno
changed the title
https://github.com/osrf/ros2_java/pull/1_)
ivanpauno
changed the title
ivanpauno
changed the title
jacobperron
reviewed
Nov 12, 2021
ivanpauno
force-pushed
the
ivanpauno/port-changes-from-fork
branch
from
7e60465 to
f55626b
Compare
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno
force-pushed
the
ivanpauno/port-changes-from-fork
branch
from
f55626b to
086e700
Compare
Contributor
Author
|
Commented out some test files to match the state on osrf#1. |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port osrf#1