Exit with code 0 if ExternalShutdownException is raised #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an expected exception from the executor on a keyboard interrupt, so I don't think it should be an error. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
jacob/py_exit_zero
branch
from
07a23f8
to
5b16ddb
Compare
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ivanpauno
approved these changes
Aug 5, 2022
|
cardboardcode
pushed a commit
to cardboardcode/demos
that referenced
this pull request
Jan 23, 2023
* Exit with code 0 if ExternalShutdownException is raised This is an expected exception from the executor on a keyboard interrupt, so I don't think it should be an error. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
cardboardcode
pushed a commit
to cardboardcode/demos
that referenced
this pull request
Jan 23, 2023
* Exit with code 0 if ExternalShutdownException is raised This is an expected exception from the executor on a keyboard interrupt, so I don't think it should be an error. Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an expected exception from the executor on a sigint, so I don't think it should be an error. Correct me if you think otherwise.