-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added README.md for image_tools #571
Conversation
Apologies for the long delay. I now have the bandwidth to see this Pull Request through now that I am on holiday. Will respond to requests to edit/improve the added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this ! Looks good to me with the following minor comments resolved.
Hi @adityapande-1995 and @clalancette, thank you for the prompt review. I have updated the current However, I have also further edited the draft to adhere to the style of instructions similar to the approved Pull Request 572. Enquiries
|
Yes, force-pushing is fine; it is pretty common practice, exactly to fix the DCO type issues. |
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
…os2#578) This is the recommendation from the ROS 2 tutorials. Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
* Exit with code 0 if ExternalShutdownException is raised This is an expected exception from the executor on a keyboard interrupt, so I don't think it should be an error. Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
* ➕ 📖 Added README.md for dummy_map_server ROS2 package. Verified instructions. Signed-off-by: Bey Hao Yun <beyhy94@gmail.com> * Update dummy_robot/dummy_map_server/README.md Decomposed sentence into smaller sizes. Co-authored-by: Audrow Nash <audrow@hey.com> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com> * Update dummy_robot/dummy_map_server/README.md Reworded. Co-authored-by: Audrow Nash <audrow@hey.com> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com> * 🔨 Modified use of --packages-select to --packages-up-to based on feedback. Signed-off-by: Bey Hao Yun <beyhy94@gmail.com> * 🔨 Modified README.md further to adhere to feedback given. Signed-off-by: Bey Hao Yun <beyhy94@gmail.com> * 🔨 Modified README.md commands to adhere to higher cross-platform compatibility. Signed-off-by: Bey Hao Yun <beyhy94@gmail.com> * Update dummy_robot/dummy_map_server/README.md Co-authored-by: Audrow Nash <audrow@hey.com> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com> Co-authored-by: Audrow Nash <audrow@hey.com> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
It is now properly included in the rosidl dependency chain. Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
* WIP: python examples for async parameter client Signed-off-by: Brian Chen <brian.chen@openrobotics.org> * reorganize Signed-off-by: Brian Chen <brian.chen@openrobotics.org> * linting & use tempfile Signed-off-by: Brian Chen <brian.chen@openrobotics.org> * linting Signed-off-by: Brian Chen <brian.chen@openrobotics.org> * put async_param_server node in async_param_client Signed-off-by: Brian Chen <brian.chen@openrobotics.org> * address review comments Signed-off-by: Brian Chen <brian.chen@openrobotics.org> * delete param demo with static and non-static param Signed-off-by: Brian Chen <brian.chen@openrobotics.org> * tabs aren't valid yaml Signed-off-by: Brian Chen <brian.chen@openrobotics.org> * decrease demo complexity Signed-off-by: Brian Chen <brian.chen@openrobotics.org> * use parameter blackboard Signed-off-by: Brian Chen <brian.chen@openrobotics.org> * add warning if wait_for_services fails to demo Signed-off-by: Brian Chen <brian.chen@openrobotics.org> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
It wasn't being installed previously, which means it couldn't be used with 'ros2 launch' Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
* local parameter callback support Signed-off-by: deepanshu <deepanshubansal01@gmail.com> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
* Make demo_nodes_cpp_native install stuff only when it builds Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * doing nothing -> skipping Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Co-authored-by: Audrow Nash <audrow@hey.com> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
The main reason to do this is so that we can compile the demos with the clang static analyzer. As of clang++-14 (what is in Ubuntu 22.04), the default still seems to be C++14, so we need to specify C++17 so that new things in the rclcpp headers work properly. Further, due to reasons I don't fully understand, I needed to set CMAKE_CXX_STANDARD_REQUIRED in order for clang to really use that version. So set this as well. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
…y approved standards. Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
Signed-off-by: Bey Hao Yun <beyhy94@gmail.com>
9dad8f4
to
b8232d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this PR should be rebased on a newly pulled rolling branch. That way, the PR doesn't have a bunch of unrelated commits.
Will do. @audrow Should I create a new Pull Request for this added Asking because it seems it is not possible to rebase it cleanly in the current Pull Request. |
That sounds okay to me. You can mention this PR in the new PR so that it's easier to trace the feedback. I think it would also be possible to start from the rolling branch, cherry-pick your commits here on to the rolling branch, and then force push to this branch, but whatever you think is easier. |
Created a new pull request with a cleaner set of commits that has been rebased from the updated rolling branch. Closing. Please refer to Pull Request #596 for continuation of this thread. |
Purpose of Pull Request
This pull request adds a
README.md
to image_tools as part of efforts to address the issue highlighted in #531.Edits Made:
README.md
under /image_tools directory..png
picture for verifying that the ROS2 package works.