Update dummy_sensors readme to echo the correct topic #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmackay2
requested review from
adityapande-1995,
audrow and
mjeronimo
as code owners
fujitatomoya
approved these changes
May 4, 2024
|
@marcoag @clalancette can you merge this and backports? |
marcoag
previously requested changes
May 6, 2024
Signed-off-by: jmackay2 <1.732mackay@gmail.com>
I've retargeted it to |
marcoag
approved these changes
May 6, 2024
|
@Mergifyio backport jazzy iron humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 6, 2024
Signed-off-by: jmackay2 <1.732mackay@gmail.com> (cherry picked from commit eec5c12)
mergify bot
pushed a commit
that referenced
this pull request
May 6, 2024
Signed-off-by: jmackay2 <1.732mackay@gmail.com> (cherry picked from commit eec5c12)
This was referenced May 6, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 6, 2024
Signed-off-by: jmackay2 <1.732mackay@gmail.com> (cherry picked from commit eec5c12) # Conflicts: # dummy_robot/dummy_sensors/README.md
clalancette
pushed a commit
that referenced
this pull request
May 6, 2024
clalancette
pushed a commit
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output topic of
dummy_laseris/scan. This just updates the README to inform the user to echo the/scantopic instead of the/lasertopic. This was found while testing osrf/ros2_test_cases#1202.