Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax highlighting #253

Merged
merged 2 commits into from Mar 9, 2020
Merged

Conversation

ruffsl
Copy link
Member

@ruffsl ruffsl commented Aug 27, 2019

@ruffsl
Copy link
Member Author

ruffsl commented Feb 21, 2020

@jacobperron , could we get this merged soon? I have some upcoming PRs that could benefit from the improved readability of code snippets using rendered syntax highlighting on the static design site.

@mjcarroll mjcarroll self-assigned this Feb 21, 2020
@mjcarroll
Copy link
Member

Is there currently a page that would take advantage of this?

@ruffsl
Copy link
Member Author

ruffsl commented Feb 21, 2020

Is there currently a page that would take advantage of this?

Any of the pages showing XML snippets, like all of the roslauch XML or security policy schema docs.
Those long schemas and sub snippets are hard to read with no tag/attribute/comment highlighting.

@mjcarroll
Copy link
Member

2020-02-21-170852_2185x447_scrot

Definitely an improvement.

@mjcarroll
Copy link
Member

Can you include the license for the default.css? I believe it is unlicense based on a quick look.

@ruffsl
Copy link
Member Author

ruffsl commented Feb 21, 2020

Can you include the license for the default.css?

Sure, but

I believe it is unlicense based on a quick look.

then what does that kind of license header look like?

@mjcarroll
Copy link
Member

I saw this in the pygments repo: https://github.com/richleland/pygments-css/blob/master/UNLICENSE.txt

@ruffsl
Copy link
Member Author

ruffsl commented Mar 9, 2020

Ping @mjcarroll , any further actions necessary?

@mjcarroll mjcarroll merged commit 9330419 into ros2:gh-pages Mar 9, 2020
@mjcarroll
Copy link
Member

Thanks for the improvement!

mlanting pushed a commit to mlanting/design that referenced this pull request Aug 17, 2020
mlanting pushed a commit to mlanting/design that referenced this pull request Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants