-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mdast-lint based markdown checking #67
Conversation
Thank you for putting together the PR. We should probably refer to a more complete style guide from our wiki page. Maybe http://www.cirosantilli.com/markdown-style-guide/ Based on that we can figure out if the configuration in this patch should be adjusted or if the existing markdown files should be updated. There are two aspects to consider for selecting the linter to be used:
|
I’d suggest mdast 😉 There’s also an external lint-rule for “option-wrap-sentence”: https://github.com/chcokr/mdast-lint-sentence-newline, which I think does exactly what you’d like? |
added external rule |
Trying out mdast checking from #67
I've tried this out locally in atom. (The linter-markdown requires updating .mdastrc and manually installing the sentence plugin into the ~/.atom/packages/linter-markdown) There was one flag that I could not resolve which was that the use of |
Sadly we haven't taken any actions on this PR for a while and by now |
As suggested in #34, this PR introduces checking of the markdown files in
articles/
, failing the travis build when style errors are found.Example output: https://travis-ci.org/tkruse/design/builds/88631913
The inner README.md file provides some info and instructions to run locally. The commands could be wrapped in shell or Makefile scripting, but I did not add that since I don't know your preferences.
Notes:
pygments.rb
inGemfile
to get things to run on travis.