-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run condition for composable nodes #311
Run condition for composable nodes #311
Conversation
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Aditya <aditya050995@gmail.com>
@adityapande-1995 could you fix CI failures? |
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Got green CI, merging ! |
Any chance this can be backported to Humble? We just had a MoveIt user find an issue with something related to this change not being in Humble. |
I don't see any reason why not after looking at it. Care to open a PR? |
@Mergifyio backport humble |
✅ Backports have been created
|
* Added run condition for composable nodes Signed-off-by: Aditya <aditya050995@gmail.com> (cherry picked from commit a14156e)
Signed-off-by: Aditya aditya050995@gmail.com
Summary
This PR adds the
condition
parameter to composable nodes action. Resolves #294. This action is currently supported byComposableNodeContainer
but notComposableNode
itself.Example usage
One can use the following example file :
or alternatively as an xml,
Running this as
ros2 launch test.py flag:=True
will make it launchtalker_1
andtalker_3
, andFalse
will make it launchtalker_2
andtalker_3
.