Vendor same version as Jammy (v0.2.2) #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <yadunund@openrobotics.org>
clalancette
requested changes
Apr 20, 2023
Comment on lines
+116
to
+118
| # Build yaml if the system version is greater than 0.2.2 | ||
| elseif("${yaml_VERSION}" VERSION_GREATER 0.2.2) | ||
| set(_SKIP_YAML_BUILD 0) |
There was a problem hiding this comment.
We discussed this in the Waffle meeting today. The general feeling was that it is OK to enforce a maximum, but we probably shouldn't do it so strictly. For instance, our rosdep keys don't make this enforcement. So the suggestion here is to only build locally if the system version is greater than the next minor version, i.e. this check should be >= 0.3.0.
|
@Yadunund what is the status of this? Since rolling is no longer on Jammy, does it make sense to apply this? |
Ah yes, good call. We already updated this to 0.2.5 to match Ubuntu 24.04, so we can close this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the version of libyaml vendored from
0.2.5to0.2.2, ie the same version as debian in Jammy It also forces build if the version of the system package is greater than0.2.2.CI: