Skip to content

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 22, 2025

Description

Some fixes to documentation

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Sep 22, 2025
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nitpicks, lgtm.


.. code-block:: console
$ colcon build && . install/setup.bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent is one space off compared to other lines?

Suggested change
$ colcon build && . install/setup.bash
$ colcon build && . install/setup.bash


.. code-block:: console
$ colcon build && . install/setup.bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here?


.. code-block:: console
$ colcon build && . install/setup.bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here?

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde merged commit e849a8e into rolling Sep 25, 2025
2 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/improve_documentation branch September 25, 2025 09:24
@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 25, 2025

https://github.com/Mergifyio backport kilted jazzy humble

Copy link

mergify bot commented Sep 25, 2025

backport kilted jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 25, 2025
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit e849a8e)
mergify bot pushed a commit that referenced this pull request Sep 25, 2025
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit e849a8e)

# Conflicts:
#	doc/Tutorials/Approximate-Synchronizer-Cpp.rst
#	doc/Tutorials/Approximate-Synchronizer-Python.rst
#	doc/Tutorials/Writing-A-Time-Synchronizer-Python.rst
mergify bot pushed a commit that referenced this pull request Sep 25, 2025
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit e849a8e)

# Conflicts:
#	doc/Tutorials/Approximate-Synchronizer-Cpp.rst
#	doc/Tutorials/Approximate-Synchronizer-Python.rst
#	doc/Tutorials/Writing-A-Time-Synchronizer-Python.rst
@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 25, 2025

This is just documentation, merging!

ahcorde added a commit that referenced this pull request Sep 25, 2025
(cherry picked from commit e849a8e)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde pushed a commit that referenced this pull request Sep 25, 2025
* Some fixes to documentation (#208)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit e849a8e)
ahcorde pushed a commit that referenced this pull request Sep 25, 2025
* Some fixes to documentation (#208)

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit e849a8e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants