[rcl_action] Add function to check if goal can be transitioned to CANCELING #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CANCELING Add unit tests for the new function rcl_action_goal_handle_is_cancelable(), as well as rcl_action_goal_handle_is_active().
jacobperron
added
in review
|
hidmic
approved these changes
Nov 13, 2018
| * \return `true` if the goal handle is valid, `false` otherwise, also | ||
| * \return `false` if the goal handle pointer is null | ||
| * \return `true` if the goal handle is valid, or | ||
| * \return `false` if the goal handle pointer is null, |
There was a problem hiding this comment.
@jacobperron missing trailing or.
|
nburek
pushed a commit
to nburek/rcl
that referenced
this pull request
Nov 26, 2018
…CELING (ros2#325) * [rcl_action] Add function for checking if goal can be transitioned to CANCELING Add unit tests for the new function rcl_action_goal_handle_is_cancelable(), as well as rcl_action_goal_handle_is_active().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for the new function rcl_action_goal_handle_is_cancelable(), as well as rcl_action_goal_handle_is_active().
This is a useful function for the action server implementation (#323).