Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support wildcards for just namespaces, or just nodes #1265

Open
rpaaron opened this issue Aug 9, 2020 · 13 comments
Open

support wildcards for just namespaces, or just nodes #1265

rpaaron opened this issue Aug 9, 2020 · 13 comments
Labels

Comments

@rpaaron
Copy link
Contributor

rpaaron commented Aug 9, 2020

Feature request

Feature description

support wildcards for just namespaces, or just nodes

/**:
    ros__parameters:
        applies_to_all_nodes_in_all_namespaces: true

would be nice also to have

some_namespace:
    *:
        ros__parameters:
            applies_to_all_nodes_in_particular_namespace: true

and

/*:
    some_node:
        ros__parameters:
            applies_to_particular_node_in_all_namespaces: true

is there a way currently to achieve this?

@fujitatomoya
Copy link
Collaborator

I think that it would be really nice to describe wildcard format in https://index.ros.org/doc/ros2/Tutorials/Node-arguments/#setting-parameters-from-yaml-files. (After this PR is merged.)

@clalancette
Copy link
Contributor

@rpaaron Thanks for the issue and the pull request implementing it. Before we go too far on the implementation, though, we should settle on the design first. Towards that end, could you please propose a modification to http://design.ros2.org/articles/static_remapping.html for the design? Thanks.

@jacobperron
Copy link
Member

Correct me if I'm wrong, but using wildcards as proposed here looks consistent with how name matching is described in the design doc. It still might be useful to add concrete examples when it comes to using them in parameter files, either in the design doc or in the tutorial as @fujitatomoya suggests.

@rpaaron
Copy link
Contributor Author

rpaaron commented Oct 12, 2020

I think these changes are inline with what's written in the design document already. If not, could someone please advise what needs to change.

jacobperron added a commit to ros2/design that referenced this issue Oct 12, 2020
Wildcards were introduced in ros2/rclcpp#762
And further usage proposed in ros2/rclcpp#1265.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member

It wasn't obvious to me where the best place to document this feature is, but I think I've found an appropriate place and opened a PR: ros2/design#303

Reviews are appreciated 🙂

@AlexKaravaev
Copy link

Are there any plans on merging this? Or maybe achieving same functionality with latest rolling distrib.

I think this feature is quite helpful

fujitatomoya pushed a commit to ros2/design that referenced this issue Dec 17, 2021
* Describe wildcard usage in parameter files

Wildcards were introduced in ros2/rclcpp#762
And further usage proposed in ros2/rclcpp#1265.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Reformat examples

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@clalancette clalancette added backlog and removed more-information-needed Further information is required labels Feb 3, 2022
@fujitatomoya
Copy link
Collaborator

#1839 should also fix this problem.

@fujitatomoya
Copy link
Collaborator

@AlexKaravaev it would be really nice if you could check that #1839 fixes your problem.

@tonynajjar
Copy link
Contributor

This should be solved right?

@tonynajjar
Copy link
Contributor

tonynajjar commented Jul 4, 2023

On the other hand, I noticed that this is not fixed for Composable Nodes. More specifically, a Composable node named talker that loads the following param file, will not load topic_name.

/**:
  talker:
    ros__parameters:
      topic_name: overriden_topic_name

Any idea why? Is this a bug in #1839 or composable nodes have a different implementation?

@fujitatomoya
Copy link
Collaborator

@iuhilnehc-ynos can you check #1265 (comment)?

@iuhilnehc-ynos
Copy link
Collaborator

iuhilnehc-ynos commented Jul 13, 2023

Please see #715 (comment) or ros2/launch_ros#156 (comment).

@iuhilnehc-ynos
Copy link
Collaborator

iuhilnehc-ynos commented Jul 13, 2023

ComposableNode supported both formats in ros2/launch_ros#259.
I think we need a follow-up PR to support wildcards for ComposableNode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants