-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support wildcards for just namespaces, or just nodes #1265
Comments
I think that it would be really nice to describe wildcard format in https://index.ros.org/doc/ros2/Tutorials/Node-arguments/#setting-parameters-from-yaml-files. (After this PR is merged.) |
@rpaaron Thanks for the issue and the pull request implementing it. Before we go too far on the implementation, though, we should settle on the design first. Towards that end, could you please propose a modification to http://design.ros2.org/articles/static_remapping.html for the design? Thanks. |
Correct me if I'm wrong, but using wildcards as proposed here looks consistent with how name matching is described in the design doc. It still might be useful to add concrete examples when it comes to using them in parameter files, either in the design doc or in the tutorial as @fujitatomoya suggests. |
I think these changes are inline with what's written in the design document already. If not, could someone please advise what needs to change. |
Wildcards were introduced in ros2/rclcpp#762 And further usage proposed in ros2/rclcpp#1265. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
It wasn't obvious to me where the best place to document this feature is, but I think I've found an appropriate place and opened a PR: ros2/design#303 Reviews are appreciated 🙂 |
Are there any plans on merging this? Or maybe achieving same functionality with latest rolling distrib. I think this feature is quite helpful |
* Describe wildcard usage in parameter files Wildcards were introduced in ros2/rclcpp#762 And further usage proposed in ros2/rclcpp#1265. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Reformat examples Signed-off-by: Jacob Perron <jacob@openrobotics.org>
#1839 should also fix this problem. |
@AlexKaravaev it would be really nice if you could check that #1839 fixes your problem. |
This should be solved right? |
On the other hand, I noticed that this is not fixed for Composable Nodes. More specifically, a Composable node named
Any idea why? Is this a bug in #1839 or composable nodes have a different implementation? |
@iuhilnehc-ynos can you check #1265 (comment)? |
Please see #715 (comment) or ros2/launch_ros#156 (comment). |
|
Feature request
Feature description
support wildcards for just namespaces, or just nodes
would be nice also to have
and
is there a way currently to achieve this?
The text was updated successfully, but these errors were encountered: