-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_subscription_topic_statistics fails with rmw_connext_cpp #1403
Comments
I can reproduce this failure, and the
I am sure it's introduced in #1281. #1281 lost logic,
|
@dabonnie does @iuhilnehc-ynos comment make sense to you? |
I don't think so (context here). For that test I'm curious why it's only failing for connext. Notice how line 243 introduces a check for empty messages, which is used at line 416 to assert that empty header messages are empty. IMHO the continue block is just hiding a failure, where we don't expect a message to have empty fields at that point. |
Since we aren't using |
This is a reoccuring failure over at:
http://build.ros2.org/view/Rci/job/Rci__nightly-connext_ubuntu_focal_amd64/106/testReport/rclcpp/TestSubscriptionTopicStatisticsFixture/test_receive_stats_for_message_no_header/
It was probably introduced in #1281, which aligns with when this failure started showing up.
The text was updated successfully, but these errors were encountered: