Flaky timer test fix #2469
Merged
Flaky timer test fix #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 31, 2024 12:13
Signed-off-by: Janosch Machowinski <j.machowinski@nospam.org>
…ions Signed-off-by: Janosch Machowinski <j.machowinski@nospam.org>
jmachowinski
requested review from
ivanpauno,
hidmic and
wjwwood
as code owners
fujitatomoya
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
lgtm.
I am not sure how much https://ci.ros2.org/job/ci_linux/20668/testReport/ could be addressed by these racy conditions (since all failed with StatisSingleThreadedExecutor, only accessing timer's data can be affected.) but obviously nice to fix.
|
@jmachowinski thanks for the fix. Regardless ros2/rcl#1142, this is better to fix. i will start CI. |
|
CI:
|
|
@fujitatomoya Yes, this patch just fixes the flakyness of the test. |
|
https://ci.ros2.org/job/ci_windows/21385/ is unrelated, i will go ahead to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed some issues reported in ros2/rcl#1142
@clalancette, @mjcarroll , @fujitatomoya , @wjwwood