update RCL_RET_TIMEOUT error handling with action service response. #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Mar 22, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
CI:
|
|
https://ci.ros2.org/job/ci_windows/21314/testReport/ is unrelated. |
alsora
approved these changes
Mar 26, 2024
|
@sloretz @fujitatomoya any chance we could backport this to Humble? |
|
@Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 1, 2024
…1258) * update RCL_RET_TIMEOUT error handling with action service response. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * address review comment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 2ec6797)
mergify bot
pushed a commit
that referenced
this pull request
May 1, 2024
…1258) * update RCL_RET_TIMEOUT error handling with action service response. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * address review comment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 2ec6797)
fujitatomoya
added a commit
that referenced
this pull request
May 3, 2024
…1258) (#1276) * update RCL_RET_TIMEOUT error handling with action service response. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * address review comment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 2ec6797) Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
added a commit
that referenced
this pull request
May 3, 2024
…1258) (#1277) * update RCL_RET_TIMEOUT error handling with action service response. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * address review comment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 2ec6797) Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of ros2/ros2#1462