Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sigint guard condition's lifecycle bug (#288) #298

Merged
merged 1 commit into from
Mar 29, 2019
Merged

fix sigint guard condition's lifecycle bug (#288) #298

merged 1 commit into from
Mar 29, 2019

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Mar 29, 2019 •
edited
Loading

Cherry-pick of #288 for crystal patch release 4 ros2/ros2#668

closes #295

@sloretz sloretz added the in review Waiting for review (Kanban column) label Mar 29, 2019
@sloretz sloretz self-assigned this Mar 29, 2019
@reed-lau @sloretz
fix sigint guard condition's lifecycle bug (#288)
0a20806 
* fix #215

Signed-off-by: reed-lau <geoliuwei@gmail.com>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz force-pushed the backport_288_crystal_patch_4 branch from d8c4569 to 0a20806 Compare March 29, 2019 22:35
@sloretz
Copy link
Contributor Author

sloretz commented Mar 29, 2019

First try at CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

wjwwood
wjwwood approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though I only skimmed the history of the issue. It should be safe to backport to crystal though.

@sloretz sloretz merged commit 3ba2c48 into crystal Mar 29, 2019
@sloretz sloretz deleted the backport_288_crystal_patch_4 branch March 29, 2019 23:32
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Mar 29, 2019
@nuclearsandwich nuclearsandwich mentioned this pull request Apr 4, 2019
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@wjwwood wjwwood wjwwood approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sloretz @wjwwood @jacobperron @reed-lau