-
Notifications
You must be signed in to change notification settings - Fork 111
Adds {severity_with_color} as a log format option. #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rolling
Are you sure you want to change the base?
Conversation
Signed-off-by: Alex MacLean <macleale@amazon.com>
4cad812 to
b7a4469
Compare
Signed-off-by: Alex MacLean <macleale@amazon.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Alex MacLean <alex@macleanfam.org>
Signed-off-by: Alex MacLean <macleale@amazon.com>
0b8c24c to
8674a60
Compare
|
@ahcorde waffle team is assigning this to you. Commenting so I see when it gets merged so I can share it with the community. |
ahcorde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind to add some documentation on ros2_documentation about how to use this new feature ?
|
Pulls: #526 |
Happy to. I'll update the documentation on Monday, and create a pull request to |
|
Added documentation: ros2/ros2_documentation#6045 |
|
@ahcorde - I'm trying to decipher the build failures that you listed. Are those build infrastructure errors? I don't see compile or test failures in the console output. I only see IO Exceptions for Jenkins and Hudson. |
Description
This change adds a new log formatting token option:
{severity_with_color}. When used in the log format string, the severity level will be colorized in the log output, but the rest of the line will not be affected. IfRCUTILS_COLORIZED_OUTPUT=1, causing the entire line to be colorized,{severity_with_color}behaves the same as{severity}.Example usage:
Is this user-facing behavior change?
Yes. It allows users to use
{severity_with_color}in their log format.Did you use Generative AI?
No
Additional Information