Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FASTDDS_BUILTIN_TRANSPORTS env value doc. #750

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

fujitatomoya
Copy link
Collaborator

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

CC: @EduPonz @MiguelCompany

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-and-large-data-transfer-on-lossy-networks/36598/6

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@EduPonz requesting 2nd review, thanks!

Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small NIT that was not correct on my original suggestion

README.md Outdated Show resolved Hide resolved
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@EduPonz ping

@fujitatomoya fujitatomoya merged commit 829cde3 into rolling Mar 25, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fujitatomoya/doc-large-data-transport branch March 25, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants