-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tutorial for creating a workspace #359
Conversation
Signed-off-by: maryaB-osr <marya@openrobotics.org>
|
||
.. code-block:: bash | ||
|
||
. ~/ros2_install/ros2-osx/setup.bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wanted to make sure to embed the distro name into the directory for macOS / Windows too, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this do it #380 ?
|
||
cd dev_ws | ||
|
||
In the root, source your overlay: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the user has already sourced the underlay they only need to source the local_setup
file of the overlay.
Or they just source the setup
file of the overlay which implicitly will source the underlay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, an explanation of the difference between setup.bash
and local_setup.bash
would probably be good here. It's a question I get a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this note:
.. note::
Sourcing the ``local_setup`` of the overlay will only add the packages available in the overlay to your environment.
``setup`` sources the overlay as well as the underlay it was created in, allowing you to utilize both workspaces.
So, sourcing your main ROS 2 installation's ``setup`` and then the ``dev_ws`` overlay's ``local_setup``, like you just did,
is the same as just sourcing ``dev_ws``'s ``setup``, because that includes the environment of the underlay it was created in.
Does that make sense?
|
||
.. code-block:: bash | ||
|
||
sudo rosdep install -i --from-path src --rosdistro <distro> -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a tutorial that talks about rosdep
? Otherwise, this is kind of magical. If we do have a tutorial talking about rosdep
, we should probably have some language saying that you'll learn about it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. there is a bit more about dependencies once they start creating their own packages, but not much more about rosdep
specifically. I'll say "later" for now and make a note to add more in-depth notes about rosdep
. I also think the opening and closing lines of this section provide a sufficient temporary introduction, albeit very vague
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with punting on rosdep for now. I've opened #381 to track adding a tutorial about rosdep.
|
||
cd dev_ws | ||
|
||
In the root, source your overlay: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, an explanation of the difference between setup.bash
and local_setup.bash
would probably be good here. It's a question I get a lot.
Signed-off-by: maryaB-osr <marya@openrobotics.org>
Signed-off-by: maryaB-osr <marya@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a few more suggestions but otherwise it looks good to me.
For quick reference the tutorial can be reviewed at: https://ros2-documentation-pr-359.herokuapp.com/Tutorials/Workspace/CreatingAWorkspace.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got a few more nits to fix.
Co-Authored-By: Tully Foote <tfoote@osrfoundation.org>
Co-Authored-By: Tully Foote <tfoote@osrfoundation.org>
Co-Authored-By: Tully Foote <tfoote@osrfoundation.org>
Signed-off-by: maryaB-osr <marya@openrobotics.org>
… into tutorial11 Signed-off-by: maryaB-osr <marya@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but you'll want to fix the failing CI before merging.
Signed-off-by: maryaB-osr <marya@openrobotics.org>
* Environment config tutorial (#334) * Environment config tutorial Signed-off-by: maryaB-osr <marya@openrobotics.org> * Added pages to some empty links for CI check Signed-off-by: maryaB-osr <marya@openrobotics.org> * Add requirements.txt and app.json for Heroku build (#336) This enables heroku "review apps" Signed-off-by: Michael Carroll <michael@openrobotics.org> * Addressed reviews and implemented tabs Signed-off-by: maryaB-osr <marya@openrobotics.org> * Added tabs install instructions for travis Signed-off-by: maryaB-osr <marya@openrobotics.org> * Fixed Travis warnings Signed-off-by: maryaB-osr <marya@openrobotics.org> * Prereqs note about using debs. for linux Signed-off-by: maryaB-osr <marya@openrobotics.org> * Added reference for linking Signed-off-by: maryaB-osr <marya@openrobotics.org> * Update Goal statement Co-Authored-By: Jacob Perron <jacob@openrobotics.org> * Remove leading arrowhead from Windows command Co-Authored-By: Jacob Perron <jacob@openrobotics.org> * Empty line before .. todo: Co-Authored-By: Jacob Perron <jacob@openrobotics.org> * "value" to "integer" for ROS_DOMAIN_ID Co-Authored-By: Jacob Perron <jacob@openrobotics.org> * Added ROS_DOMAIN_ID explanation Signed-off-by: maryaB-osr <marya@openrobotics.org> * Link to ROS Answers Also left a note to test Windows domain ID command Signed-off-by: maryaB-osr <marya@openrobotics.org> * Syntax error on ROS answers link Signed-off-by: maryaB-osr <marya@openrobotics.org> * Changed domainID tabs to include script command Signed-off-by: maryaB-osr <marya@openrobotics.org> * Fixed too much indentation Signed-off-by: maryaB-osr <marya@openrobotics.org> * Update Windows ROS_DOMAIN_ID config section (#341) * Update Windows ROS_DOMAIN_ID config section Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update source/Tutorials/ConfiguringROS2Environment.rst Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * New tutorial for introducing turtlesim for ROS 2 (#342) * New tutorial for introducing turtlesim for ROS 2 Signed-off-by: maryaB-osr <marya@openrobotics.org> * Trying one image Signed-off-by: maryaB-osr <marya@openrobotics.org> * New file not included in toctree Signed-off-by: maryaB-osr <marya@openrobotics.org> * All images and fix toctree (?) Signed-off-by: maryaB-osr <marya@openrobotics.org> * More concise goal statement Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * Update Windows ROS_DOMAIN_ID config section (#341) * Update Windows ROS_DOMAIN_ID config section Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Update source/Tutorials/ConfiguringROS2Environment.rst Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * Removed ros2 run explanation (for next tutorial) Signed-off-by: maryaB-osr <marya@openrobotics.org> * "turtled" to "turtle" Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * clalancette's requested changes Signed-off-by: maryaB-osr <marya@openrobotics.org> * dirk-thomas's requested changes Signed-off-by: maryaB-osr <marya@openrobotics.org> * forgot to remove "2" from file name Signed-off-by: maryaB-osr <marya@openrobotics.org> * fixed backticks and added sentence about pen Signed-off-by: maryaB-osr <marya@openrobotics.org> * corrections from dirk-thomas Signed-off-by: maryaB-osr <marya@openrobotics.org> * New tutorial on ROS 2 topics (#344) * New tutorial on ROS 2 topics Signed-off-by: maryaB-osr <marya@openrobotics.org> * removed random ? Signed-off-by: maryaB-osr <marya@openrobotics.org> * comment out empty reference Signed-off-by: maryaB-osr <marya@openrobotics.org> * remove "on" Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * clarify topics definition Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * "process" > "topic" Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * reword "command line introspection" Co-Authored-By: William Woodall <william+github@osrfoundation.org> * properly name topics and nodes Co-Authored-By: William Woodall <william+github@osrfoundation.org> * clarify not all robots need a data stream Co-Authored-By: William Woodall <william+github@osrfoundation.org> * typo "you" > "your" Co-Authored-By: William Woodall <william+github@osrfoundation.org> * address comments on definition of topics Signed-off-by: maryaB-osr <marya@openrobotics.org> * Rearrange background info Signed-off-by: maryaB-osr <marya@openrobotics.org> * typo Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * minor edits Signed-off-by: maryaB-osr <marya@openrobotics.org> * New tutorial on ROS 2 services (#346) * New tutorial on ROS 2 services Signed-off-by: maryaB-osr <marya@openrobotics.org> * adding links on turtlesim, config, topics Signed-off-by: maryaB-osr <marya@openrobotics.org> * removed cluttered parameter services Signed-off-by: maryaB-osr <marya@openrobotics.org> * YAML syntax only on cmd line Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * specified synchronous services will wait Signed-off-by: maryaB-osr <marya@openrobotics.org> * single quotes inside double quotes Co-Authored-By: Scott K Logan <logans@cottsay.net> * addressed cottsay's reviews Signed-off-by: maryaB-osr <marya@openrobotics.org> * more intuitive topics/services description Signed-off-by: maryaB-osr <marya@openrobotics.org> * more concise wording Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * missing comma Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * typo Signed-off-by: maryaB-osr <marya@openrobotics.org> * New tutorial for ROS 2 parameters (#347) * New tutorial for ROS 2 parameters Signed-off-by: maryaB-osr <marya@openrobotics.org> * Forgot toctree and goal statement Signed-off-by: maryaB-osr <marya@openrobotics.org> * italics > bold Signed-off-by: maryaB-osr <marya@openrobotics.org> * small edits based on reviews Signed-off-by: maryaB-osr <marya@openrobotics.org> * Change the main README to say to use pip for sphinx and required sphinx-tab installation. (#363) Add sphinx and sphinx-tab into requirements.txt Clarify to use pip3 so people implicitly know that python3 is required Further clarify sphinx requirements * New tutorial for ROS 2 nodes (#343) * New tutorial for ROS 2 nodes Signed-off-by: maryaB-osr <marya@openrobotics.org> * commented out empty reference (for now) Also added link target to concept overview page Signed-off-by: maryaB-osr <marya@openrobotics.org> * removed pic link, added code blocks Signed-off-by: maryaB-osr <marya@openrobotics.org> * "Hopefully" sounds silly Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * "multiple nodes" to "one or more" Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * added node info with actions Signed-off-by: maryaB-osr <marya@openrobotics.org> * added links for prereqs and next steps Signed-off-by: maryaB-osr <marya@openrobotics.org> * fixed node def & added design doc link Signed-off-by: maryaB-osr <marya@openrobotics.org> * New tutorial for ROS 2 actions (#350) * New tutorial for ROS 2 actions Signed-off-by: maryaB-osr <marya@openrobotics.org> * travis warning Signed-off-by: maryaB-osr <marya@openrobotics.org> * explicitly describe action goal process Co-Authored-By: Jacob Perron <jacob@openrobotics.org> * correct services definition Co-Authored-By: Jacob Perron <jacob@openrobotics.org> * correct implemenation details Co-Authored-By: Jacob Perron <jacob@openrobotics.org> * cancel > preempt Co-Authored-By: Jacob Perron <jacob@openrobotics.org> * minor updates Signed-off-by: maryaB-osr <marya@openrobotics.org> * jacobperron's review Signed-off-by: maryaB-osr <marya@openrobotics.org> * Changed `action show` to `interface show` Signed-off-by: maryaB-osr <marya@openrobotics.org> * updated hidden actions in node info & removed bash Signed-off-by: maryaB-osr <marya@openrobotics.org> * New tutorial for ROS 2 rqt_console (#351) * New tutorial for ROS 2 rqt_console Signed-off-by: maryaB-osr <marya@openrobotics.org> * missing spaces in topic pub yaml Co-Authored-By: Michel Hidalgo <michel@ekumenlabs.com> * change tense Co-Authored-By: Michel Hidalgo <michel@ekumenlabs.com> * first > top Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * specify new terminal Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * change file names and add links to prereqs Signed-off-by: maryaB-osr <marya@openrobotics.org> * minor changes from reviews Signed-off-by: maryaB-osr <marya@openrobotics.org> * addressed reviews Signed-off-by: maryaB-osr <marya@openrobotics.org> * typo + updated remapping syntax Signed-off-by: maryaB-osr <marya@openrobotics.org> * Updated remapping syntax (#354) * Updated remapping syntax Signed-off-by: maryaB-osr <marya@openrobotics.org> * tabs for eloquent/dashing remap syntax Signed-off-by: maryaB-osr <marya@openrobotics.org> * New tutorial for ROS 2 bag files (#355) * New tutorial for ROS 2 bag files Signed-off-by: maryaB-osr <marya@openrobotics.org> * trying to make alt-text for internal links work Signed-off-by: maryaB-osr <marya@openrobotics.org> * added available links Signed-off-by: maryaB-osr <marya@openrobotics.org> * addressed reviews Signed-off-by: maryaB-osr <marya@openrobotics.org> * New tutorial for creating a workspace (#359) * New tutorial for creating a workspace Signed-off-by: maryaB-osr <marya@openrobotics.org> * typo Signed-off-by: maryaB-osr <marya@openrobotics.org> * typo Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * addressed reviews (dirk-thomas & clalancette) Signed-off-by: maryaB-osr <marya@openrobotics.org> * revert source paths until PR 380 merges Signed-off-by: maryaB-osr <marya@openrobotics.org> * underlay != main installation Co-Authored-By: Tully Foote <tfoote@osrfoundation.org> * main source not mandatory Co-Authored-By: Tully Foote <tfoote@osrfoundation.org> * underlay != main installation (again) Co-Authored-By: Tully Foote <tfoote@osrfoundation.org> * tfoote and clalancette suggestions Signed-off-by: maryaB-osr <marya@openrobotics.org> * trailing whitespace Signed-off-by: maryaB-osr <marya@openrobotics.org> * New tutorial for creating a package in ROS 2 (#362) * New tutorial for creating a package in ROS 2 Signed-off-by: maryaB-osr <marya@openrobotics.org> * addressed review from ivanpauno & sloretz Signed-off-by: maryaB-osr <marya@openrobotics.org> * ivan's final review Signed-off-by: maryaB-osr <marya@openrobotics.org> * New tutorial for ros2doctor (#378) * New tutorial for ros2doctor Signed-off-by: maryaB-osr <marya@openrobotics.org> * linter Signed-off-by: maryaB-osr <marya@openrobotics.org> * claireyywang's review Signed-off-by: maryaB-osr <marya@openrobotics.org> * New tutorial for service and client using C++ (#370) * new tutorial for service and client using C++ Signed-off-by: maryaB-osr <marya@openrobotics.org> * linter fix Signed-off-by: maryaB-osr <marya@openrobotics.org> * linter Signed-off-by: maryaB-osr <marya@openrobotics.org> * forgot package name in pkg create Signed-off-by: maryaB-osr <marya@openrobotics.org> * improve sentence structure Co-Authored-By: Michel Hidalgo <michel@ekumenlabs.com> * minor changes Signed-off-by: maryaB-osr <marya@openrobotics.org> * target > targets * Update parameters tutorial (#384) * Update parameters tutorial Signed-off-by: maryaB-osr <marya@openrobotics.org> * linter Signed-off-by: maryaB-osr <marya@openrobotics.org> * New tutorial for Python pub/sub (#364) * New tutorial for Python pub/sub Signed-off-by: maryaB-osr <marya@openrobotics.org> * fix linter issue Signed-off-by: maryaB-osr <marya@openrobotics.org> * removed mentions of line numbers, plus other reviews Signed-off-by: maryaB-osr <marya@openrobotics.org> * removed comments from long code blocks Signed-off-by: maryaB-osr <marya@openrobotics.org> * removed parenthesis from file names Signed-off-by: maryaB-osr <marya@openrobotics.org> * final nits Signed-off-by: maryaB-osr <marya@openrobotics.org> * macOS users already have dependencies installed Signed-off-by: maryaB-osr <marya@openrobotics.org> * Consistent indentation in code blocks Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * unneeded codeblock line Signed-off-by: maryaB-osr <marya@openrobotics.org> * New tutorial for service/client with Python (#372) * New tutorial for service/client with Python Signed-off-by: maryaB-osr <marya@openrobotics.org> * title underline too short Signed-off-by: maryaB-osr <marya@openrobotics.org> * trailing whitespace Signed-off-by: maryaB-osr <marya@openrobotics.org> * fix indentation and other nits Signed-off-by: maryaB-osr <marya@openrobotics.org> * Consistent indentation in code blocks Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * wrong section Signed-off-by: maryaB-osr <marya@openrobotics.org> * New tutorial for ROS 2 launch files (#353) * New tutorial for ROS 2 launch files Signed-off-by: maryaB-osr <marya@openrobotics.org> * Forgot to include in toctree Signed-off-by: maryaB-osr <marya@openrobotics.org> * trailing white space Signed-off-by: maryaB-osr <marya@openrobotics.org> * missing period Co-Authored-By: Chris Lalancette <clalancette@openrobotics.org> * inside pkg > provided by pkg Co-Authored-By: Michel Hidalgo <michel@ekumenlabs.com> * python modules explanation Co-Authored-By: Michel Hidalgo <michel@ekumenlabs.com> * handful of reviews Signed-off-by: maryaB-osr <marya@openrobotics.org> * linter & added next steps to rqt_console Signed-off-by: maryaB-osr <marya@openrobotics.org> * more trailing whitespaces... Signed-off-by: maryaB-osr <marya@openrobotics.org> * trying linenos Signed-off-by: maryaB-osr <marya@openrobotics.org> * adjust indented space on linenos Signed-off-by: maryaB-osr <marya@openrobotics.org> * another attempt at linenos indentation Signed-off-by: maryaB-osr <marya@openrobotics.org> * change indentation Signed-off-by: maryaB-osr <marya@openrobotics.org> * fix indentation on python block Signed-off-by: maryaB-osr <marya@openrobotics.org> * give up on linenos for now Signed-off-by: maryaB-osr <marya@openrobotics.org> * fixed indentation...? Signed-off-by: maryaB-osr <marya@openrobotics.org> * New tutorial for C++ pub/sub (#366) * New tutorial for C++ pub/sub Signed-off-by: maryaB-osr <marya@openrobotics.org> * try C++ code highlighting Signed-off-by: maryaB-osr <marya@openrobotics.org> * one incorrect directive Signed-off-by: maryaB-osr <marya@openrobotics.org> * fixed some indentation Signed-off-by: maryaB-osr <marya@openrobotics.org> * changed entry points to executables Signed-off-by: maryaB-osr <marya@openrobotics.org> * removed parenthesis from file name Signed-off-by: maryaB-osr <marya@openrobotics.org> * New branch for cleaning up staging This commit organizes the order of the tutorials, adds an introduction to the beginner tutorials, and hyphenates all the page names Signed-off-by: maryaB-osr <marya@openrobotics.org> * added next steps sections and other internal links Signed-off-by: maryaB-osr <marya@openrobotics.org> * change msg show to interface show Signed-off-by: maryaB-osr <marya@openrobotics.org> * linter Signed-off-by: maryaB-osr <marya@openrobotics.org>
Signed-off-by: maryaB-osr marya@openrobotics.org