Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-configured images for Rolling and Iron #3794

Merged

Conversation

ygoumaz
Copy link
Contributor

@ygoumaz ygoumaz commented Jul 25, 2023

Pre-configured images are only for Humble, so they should be removed from Rolling and Iron distributions.

This PR can be backported to Iron.

ygoumaz and others added 5 commits July 11, 2023 12:08
* Update launch files to declare WebotsController node (#11) (ros2#3763)

* change launch files

* Update Setting-Up-Simulation-Webots-Basic.rst

* update minimal version tutorial 2

* add upcoming versions

* New Reset Handler tutorial (#12) (ros2#3764)

* new tutorial

Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>

* Update macOS-Development-Setup.rst (ros2#3758)

- add Xcode App Store link
    - BASH -> ZSH (default)
    - make homebrew paths generic

Co-authored-by: Philipp Dittmann <dittmann@cs.uni-bremen.de>

* Change confusing title between Debian package and Debian platform (ros2#3771)

Currently Debian does not offer ROS2 packages. Change the title that can
be confusing.

* Make the calendar more mobile-friendly. (ros2#3774)

* Make the calendar more mobile-friendly.

When looking at some of the analytics, it looks like this
page is particularly not mobile friendly.  That's because
the Google calendar embedded on the bottom of the page
is of fixed with 800x600, which doesn't work well on
many mobile devices.

What we do here is to see if a device has 767 or less pixels.
If it does, then we just show the agenda, which fits in just
280 pixels.  If we have more than that, we have room for
the full monthly agenda, so we show the full thing.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
Co-authored-by: PhDittmann <dittmann@tzi.de>
Co-authored-by: Philipp Dittmann <dittmann@cs.uni-bremen.de>
Co-authored-by: Quentin Quadrat <lecrapouille@gmail.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@ygoumaz ygoumaz changed the title Add preconfigured 2023.1.1 Add pre-configured 2023.1.1 UTM image link to installation tutorial Jul 25, 2023
@ygoumaz ygoumaz marked this pull request as ready for review July 25, 2023 11:58
@ygoumaz ygoumaz changed the title Add pre-configured 2023.1.1 UTM image link to installation tutorial Remove pre-configured images for Rolling and Iron Jul 25, 2023
@clalancette clalancette added the backport-iron backport at reviewers discretion; from rolling to iron label Jul 25, 2023
@clalancette clalancette merged commit a053856 into ros2:rolling Jul 25, 2023
3 checks passed
mergify bot pushed a commit that referenced this pull request Jul 25, 2023
* remove pre-configured for iron and rolling

(cherry picked from commit a053856)
clalancette pushed a commit that referenced this pull request Jul 25, 2023
* remove pre-configured for iron and rolling

(cherry picked from commit a053856)

Co-authored-by: Yannick Goumaz <61198661+ygoumaz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-iron backport at reviewers discretion; from rolling to iron
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants