[ros2multicast] Use setup.py fields rather than setup.cfg #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll
force-pushed
the
multicast_setup_py
branch
from
92eb14f
to
43b8bc1
Compare
clalancette
approved these changes
Oct 3, 2019
|
Why not only move the |
None of the other packages in this repository use the |
nuclearsandwich
pushed a commit
that referenced
this pull request
Oct 14, 2019
Signed-off-by: Michael Carroll <michael@openrobotics.org>
nuclearsandwich
added a commit
that referenced
this pull request
Oct 14, 2019
* Use setup.py fields rather than setup.cfg (#346) Signed-off-by: Michael Carroll <michael@openrobotics.org> * Fix multicast entrypoint (#352) * Fix multicast entrypoint Otherwise, we see an error every time we run a ros2 command: Failed to load entry point 'multicast': No module named 'ros2node.command.multicast' Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Fix extension point Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Change version number in setup.py. Signed-Off-By: Steven! Ragnarök <steven@nuclearsandwich.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses failures in building ros2multicast for Eloquent debs.
Support for
data_filesinsetup.cfgwas introduced in setuptools v40.5.0, while Ubuntu Bionic has version39.0.1.This follows the pattern of the rest of the
ros2clipackages and puts the contents insetup.py