Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multicast entrypoint #352

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Conversation

jacobperron
Copy link
Member

Otherwise, we see an error every time we run a ros2 command:

Failed to load entry point 'multicast': No module named 'ros2node.command.multicast'

Bug introduced in #346

Otherwise, we see an error every time we run a ros2 command:

    Failed to load entry point 'multicast': No module named 'ros2node.command.multicast'

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added the bug Something isn't working label Oct 7, 2019
ros2multicast/setup.py Outdated Show resolved Hide resolved
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arg. Some terrible copy-paste. Thanks and LGTM.

@jacobperron jacobperron merged commit 159ac7a into master Oct 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/fix_multicast_entrypoint branch October 7, 2019 22:59
nuclearsandwich pushed a commit that referenced this pull request Oct 14, 2019
* Fix multicast entrypoint

Otherwise, we see an error every time we run a ros2 command:

    Failed to load entry point 'multicast': No module named 'ros2node.command.multicast'

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Fix extension point

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
nuclearsandwich added a commit that referenced this pull request Oct 14, 2019
* Use setup.py fields rather than setup.cfg (#346)

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Fix multicast entrypoint (#352)

* Fix multicast entrypoint

Otherwise, we see an error every time we run a ros2 command:

    Failed to load entry point 'multicast': No module named 'ros2node.command.multicast'

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Fix extension point

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Change version number in setup.py.

Signed-Off-By: Steven! Ragnarök <steven@nuclearsandwich.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants