Adds a --max-wait-time option to ros2 topic pub
#800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we run `ros2 topic pub -w 1 ...` we can wait for a fixed number of connections prior to shutting down. This is useful in many scenarios, however when writing automated tests it may be useful to time out if the correct number of connections are not recieved in a given amount of time. This PR adds a `--max-wait-time` option which allows users to set a timeout on how long to wait for subscribers. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
|
Just as an FYI, in general we prefer rebases of old PRs rather than new PRs. That is, it would have been preferable here to keep #797 open, and just rebase it, rather than close it and make this new one. That keeps all of the conversations in the same place and ensures it is easier to follow later. That said, it is already done here, so let's just go forward with this one. |
clalancette
requested changes
Feb 3, 2023
fujitatomoya
reviewed
Feb 3, 2023
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
fujitatomoya
approved these changes
Feb 6, 2023
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
arjo129
force-pushed
the
arjo/feat/max_wait_time_clean
branch
from
770ce08
to
58a16d1
Compare
arjo129
requested review from
clalancette
and removed request for
gbiggs and
audrow
clalancette
requested changes
Feb 6, 2023
There was a problem hiding this comment.
The code that is here looks OK to me. However, I think we should have two additional tests:
- A test that shows that using
--max-wait-time-secswithout--wait-matching-subscriptionsimmediately fails. - A test that shows that with a subscriber, we actually do eventually break out of the loop and publish something.
1 task
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
|
Added tests in ccb2864 |
clalancette
reviewed
Feb 7, 2023
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
clalancette
approved these changes
Feb 13, 2023
|
CI:
|
|
@arjo129 It looks like one of the new tests is triggering CI. Can you take a look? |
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
|
Is it possible to check CI again? I've changed the problematic test case. |
|
CI:
|
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
Another try with flake8 warnings fixed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #797
When we run
ros2 topic pub -w 1 ...we can wait for a fixed numberof connections prior to shutting down. This is useful in many scenarios,
however when writing automated tests it may be useful to time out if the
correct number of connections are not recieved in a given amount of
time. This PR adds a
--max-wait-timeoption which allows users to seta timeout on how long to wait for subscribers.
Signed-off-by: Arjo Chakravarty arjo@openrobotics.org