-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rosbag2_storage: set MCAP as default plugin #1160
Conversation
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/psa-default-ros-2-bag-storage-format-is-changing-to-mcap-in-iron/28489/1 |
f7d369b
to
de0f8ae
Compare
de0f8ae
to
0d954b8
Compare
@james-rms Am I understand correctly that we have not yet finished with adding MCAP to the |
Yes - will convert to draft until that lands. |
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2022-12-15/28840/1 |
Signed-off-by: James Smith <james@foxglove.dev>
0d954b8
to
c50c445
Compare
Signed-off-by: James Smith <james@foxglove.dev>
b660a38
to
aef7d54
Compare
Gist: https://gist.githubusercontent.com/james-rms/c4e9cba9397445f51066232f1068771d/raw/9eddb125272e274d3128068668a045b681f124fc/ros2.repos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blessing. 🤞
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-01-19/29423/1 |
switches the default storage plugin from
sqlite3
tomcap
.Reason for change
Benchmarks suggest that MCAP can support higher write throughput than the
sqlite3
plugin in its default configuration, while also bringing the following other benefits:resilient
SQLite storage plugin preset.Benchmarks
Read the benchmarking analysis that lead to this conclusion here.
rosbag2_performance_benchmarking
There is a set of pre-existing benchmarks in the rosbag2 repo here: https://github.com/ros2/rosbag2/tree/rolling/rosbag2_performance/rosbag2_performance_benchmarking
We've run these in an attempt to compare the performance of MCAP against SQLite on these metrics, but at this point the results appear to be pure noise. A full analysis of why will be published to mcap.dev shortly, but for now the news is that we have not succeeded in producing a statistically significant difference in results between MCAP and SQLite.
TODO
rosbag2_tests
direct dependence onsqlite3
#1112rosbag2_tests