Skip install when not building rosbag2_performance_benchmarking #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…marking Signed-off-by: Shane Loretz <sloretz@google.com>
sloretz
requested review from
MichaelOrlov and
jhdcs
and removed request for
a team
sloretz
added a commit
to sloretz/drake-ros
that referenced
this pull request
Feb 2, 2023
|
CI (build:
|
sloretz
added a commit
to sloretz/drake-ros
that referenced
this pull request
Feb 3, 2023
delete-merged-branch
bot
deleted the
sloretz__skip_install_when_not_building
branch
carlossvg
pushed a commit
to carlossvg/rosbag2
that referenced
this pull request
Feb 13, 2023
…marking (ros2#1242) Signed-off-by: Shane Loretz <sloretz@google.com> Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
EricCousineau-TRI
added a commit
to RobotLocomotion/drake-ros
that referenced
this pull request
Feb 16, 2023
The APIs we're using changed in ros2/rclcpp#2066, which is released in rclcpp 18.0.0 in ROS 2 rolling Additionally works around ros2/rosbag2#1242 Co-authored-by: Eric Cousineau <eric.cousineau@tri.global>
carlossvg
pushed a commit
to carlossvg/rosbag2
that referenced
this pull request
Feb 27, 2023
…marking (ros2#1242) Signed-off-by: Shane Loretz <sloretz@google.com> Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
MichaelOrlov
added a commit
that referenced
this pull request
Feb 28, 2023
…nchmarking (#1250) * Add thread pool for benchmark_publishers execution Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai> * Default the number of threads to the number of publishers Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai> * Skip ament_package() call when not building rosbag2_performance_benchmarking (#1242) Signed-off-by: Shane Loretz <sloretz@google.com> Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai> * Update rosbag2_performance/rosbag2_performance_benchmarking/include/rosbag2_performance_benchmarking/config_utils.hpp Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai> * Update rosbag2_performance/rosbag2_performance_benchmarking/include/rosbag2_performance_benchmarking/thread_pool.hpp Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai> * Update rosbag2_performance/rosbag2_performance_benchmarking/src/benchmark_publishers.cpp Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai> * Update rosbag2_performance/rosbag2_performance_benchmarking/include/rosbag2_performance_benchmarking/thread_pool.hpp Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai> * Update rosbag2_performance/rosbag2_performance_benchmarking/include/rosbag2_performance_benchmarking/thread_pool.hpp Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai> * Address reviewer comments Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai> * Address reviewer comments Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai> * Address reviewer comments Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai> --------- Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai> Signed-off-by: Shane Loretz <sloretz@google.com> Co-authored-by: Shane Loretz <sloretz@google.com> Co-authored-by: Michael Orlov <morlovmr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where
rosbag2_performance_benchmarkinggets installed to the ament resource index when it's not built, and that causes rosdep to fail to findrosbag2_performance_benchmarking_msgs.Example:
The problem is the
ament_package()call is still run whenrosbag2_performance_benchmarkingis not built, however it's dependencyrosbag2_performance_benchmarking_msgsdoes not runament_package(). This causes rosdep to thinkrosbag2_performance_benchmarkingis installed and needs it's dependencies, but the dependencyrosbag2_performance_benchmarking_msgscan't be found.I fixed it by inverting the logic and putting it at the top of the file with a
return()statement to make sure none of the logic is run when skipping this package.