Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mcap-releases-cpp- into CMakeLists.txt #1612

Merged
merged 2 commits into from
May 1, 2024
Merged

Update mcap-releases-cpp- into CMakeLists.txt #1612

merged 2 commits into from
May 1, 2024

Conversation

mosfet80
Copy link
Contributor

Update mcap-releases-cpp

@mosfet80
Update mcap-releases-cpp- into CMakeLists.txt
4075468 
Update mcap-releases-cpp- i

Signed-off-by: mosfet80 <realeandrea@yahoo.it>
@mosfet80 mosfet80 requested a review from a team as a code owner April 16, 2024 01:31
@mosfet80 mosfet80 requested review from gbiggs and james-rms and removed request for a team April 16, 2024 01:31
@MichaelOrlov
Copy link
Contributor

@clalancette, Can we also accept this PR for Jazzy as an exception?

@clalancette
Copy link
Contributor

@clalancette, Can we also accept this PR for Jazzy as an exception?

Let's not do that now. Since it is not a new feature, we can merge this in after the freeze as a fix. We should unfreeze sometime next week for that.

@MichaelOrlov
Copy link
Contributor

Ok, Thanks for letting me know.

@MichaelOrlov
Copy link
Contributor

Gist: https://gist.githubusercontent.com/MichaelOrlov/f34e25571b3893af4e9c566c3f357f6c/raw/8d16157302a0050fa019bd26a3ff0b640fd6a459/ros2.repos
BUILD args: --packages-above-and-dependencies mcap_vendor rosbag2_storage_mcap rosbag2_tests
TEST args: --packages-above mcap_vendor rosbag2_storage_mcap rosbag2_tests
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/13792

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov merged commit 3cc08f3 into ros2:rolling May 1, 2024
14 checks passed
@MichaelOrlov
Copy link
Contributor

https://github.com/Mergifyio backport Jazzy

@mergify Mergify
Copy link

mergify bot commented May 1, 2024

backport Jazzy

❌ No backport have been created

  • Backport to branch Jazzy failed

GitHub error: Branch not found

@MichaelOrlov
Copy link
Contributor

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link

mergify bot commented May 1, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 1, 2024
@mosfet80 @mergify
Update mcap-releases-cpp- into CMakeLists.txt (#1612)
be57d11 
Update mcap-releases-cpp- i

Signed-off-by: mosfet80 <realeandrea@yahoo.it>
(cherry picked from commit 3cc08f3)
@mergify mergify bot mentioned this pull request May 1, 2024
Merged
MichaelOrlov pushed a commit that referenced this pull request May 9, 2024
@mergify @mosfet80
Update mcap-releases-cpp- into CMakeLists.txt (#1612) (#1631)
daf35bb 
Update mcap-releases-cpp- i

Signed-off-by: mosfet80 <realeandrea@yahoo.it>
(cherry picked from commit 3cc08f3)

Co-authored-by: mosfet80 <realeandrea@yahoo.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner automatically assigned from ros2/tooling-reviewers

@james-rms james-rms Awaiting requested review from james-rms james-rms is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mosfet80 @MichaelOrlov @clalancette