Add optional '--topics' CLI argument for 'ros2 bag record' #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deprecate positional "topics" parameter. - Add test coverage for non-trivial cases in the recorder CLI parser. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
requested review from
gbiggs,
hidmic,
fujitatomoya and
Barry-Xu-2018
and removed request for
a team,
gbiggs and
hidmic
MichaelOrlov
changed the title
--topics CLI argument for ros2 bag record
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
|
LGTM |
|
@clalancette @emersonknapp I need a formal review/approval for this PR. |
fujitatomoya
approved these changes
May 3, 2024
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
force-pushed
the
morlov/add_optional--topics_cli_argument_for_recorder
branch
from
bb525b8
to
df50851
Compare
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/dc71cf596e1d88b0a21fc5b572384bd1/raw/b77faf036884f4558a559c99f6f6d8c6c4c8f617/ros2.repos
|
|
@clalancette @emersonknapp Friendly ping here for formal review/approval. |
emersonknapp
approved these changes
May 6, 2024
delete-merged-branch
bot
deleted the
morlov/add_optional--topics_cli_argument_for_recorder
branch
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
* Add optional "--topics" CLI parameter for recorder - Deprecate positional "topics" parameter. - Add test coverage for non-trivial cases in the recorder CLI parser. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Use "--topics" instead of positional argument in integration tests Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Cleanup in the recorder CLI help section Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add empty line to the end of the pytest.ini Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add deprecation notice for positional topics argument in help section Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 9146878)
MichaelOrlov
added a commit
that referenced
this pull request
May 23, 2024
* Add optional "--topics" CLI parameter for recorder - Deprecate positional "topics" parameter. - Add test coverage for non-trivial cases in the recorder CLI parser. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Use "--topics" instead of positional argument in integration tests Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Cleanup in the recorder CLI help section Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add empty line to the end of the pytest.ini Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add deprecation notice for positional topics argument in help section Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 9146878)
MichaelOrlov
added a commit
that referenced
this pull request
May 23, 2024
…ackport #1632) (#1640) * Add optional '--topics' CLI argument for 'ros2 bag record' (#1632) * Add optional "--topics" CLI parameter for recorder - Deprecate positional "topics" parameter. - Add test coverage for non-trivial cases in the recorder CLI parser. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Use "--topics" instead of positional argument in integration tests Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Cleanup in the recorder CLI help section Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add empty line to the end of the pytest.ini Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add deprecation notice for positional topics argument in help section Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 9146878) * Remove warning about deprecation of the positional "topics" argument Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It works currently, if put a trailing
--after the list of services. However, that workaround with trailing--is not obvious and could cause confusion and be a source of mistakes because the topics parameter can't be specified explicitly. i.e.,--topics.List of changes:
--topics" parameter for theros2 bag recordCLI interface.topics" parameter to be consistent with the"--services" parameter.--topics" parameter instead of the deprecated positional parameter in integration tests.Note: There are no API/ABI breaking changes in this PR