enforce unique node names

[Karsten1987]

fixes the unique node problem referred to in ros2/rcl#375

the template function indeed creates a new static int counter per type and thus non-unique node names when different types are used.

[Karsten1987]

• Linux
• Linux-aarch64
• macOS
• Windows

[Karsten1987]

@jacobperron the current CI fails because of ament/ament_lint#116.
how do i ensure cppcheck is correctly invoked?

[jacobperron]

@jacobperron the current CI fails because of ament/ament_lint#116.
how do i ensure cppcheck is correctly invoked?

That's unfortunate, I ended up excluding passing include directories from external packages to cppcheck because of performance:

https://github.com/ament/ament_lint/blob/4f9bfc00106496eeafa592bc5dfbc33b052d643d/ament_cmake_cppcheck/cmake/ament_cmake_cppcheck_lint_hook.cmake#L44-L47

One way around it would be to manually invoke ament_cppcheck and tell it about the header files containing the macros in rclcpp (rather than relying on ament_lint_auto). This means that you'd also have to invoke the other desired linters manually too. I think the ament_cppcheck command would look something like this:

ament_cppcheck(INCLUDE_DIRS ${rclcpp_INCLUDE_DIRS})

I think this is another instance motivating ament/ament_lint#119, or for a feature enabling more control over the configurations for the linters invoked by ament.

[dirk-thomas]

Our package template already demonstrates how individual linters part of the common linters can be skipped: https://github.com/ros2/ros2cli/blob/5dd01716edbb899e9ee270e56cf47a77b94997a2/ros2pkg/ros2pkg/resource/ament_cmake/CMakeLists.txt.em#L92-L94

[Karsten1987]

That's unfortunate, I ended up excluding passing include directories from external packages to cppcheck because of performance:

does that mean no external package can use ament_lint_auto? Or asked differently, which packages can use it? How is external defined here?
if every package has to manually exclude cppcheck then automatic lookup for linters defeats kind of the purpose, no?

[jacobperron]

does that mean no external package can use ament_lint_auto? Or asked differently, which packages can use it? How is external defined here?

To elaborate, to handle the type of error you're seeing I'd added support in ament/ament_lint#119 to pass a list of include directories to cppcheck so that it can resolve the "unknown macros". Unfortunately, a larger list of directories results in a very slow execution of cppcheck. So, when cppcheck is invoked automatically with ament_lint_auto, we limit the number of include directories to just those of the package being linted. An "external" package for the purpose of the automatic cppcheck, in this case, is anything that is not in rosbag2_transport.

[Karsten1987]

• Linux
• Linux-aarch64
• macOS
• Windows

[Karsten1987]

unrelated test errors/warnings. That means the cppcheck is correctly disabled as well as the node names are unique and don't produce any warnings.