Fix for a false negative integration test with bag split in recorder #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In record_end_to_end_with_splitting_bagsize_split_is_at_least_specified_size publisher was starting after terminating recorder. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
|
@ros-pull-request-builder retest this please |
MichaelOrlov
requested review from
gbiggs,
jhdcs,
ahcorde and
fujitatomoya
and removed request for
a team
ahcorde
approved these changes
Jul 17, 2024
|
|
https://github.com/Mergifyio backport jazzy humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
…1743) - In record_end_to_end_with_splitting_bagsize_split_is_at_least_specified_size publisher was starting after terminating recorder. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit da1acb2) # Conflicts: # rosbag2_tests/test/rosbag2_tests/test_rosbag2_record_end_to_end.cpp
MichaelOrlov
added a commit
that referenced
this pull request
Jul 19, 2024
…recorder (backport #1743) (#1751) * Fix for a false negative integration test with bag split in recorder (#1743) - In record_end_to_end_with_splitting_bagsize_split_is_at_least_specified_size publisher was starting after terminating recorder. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit da1acb2) # Conflicts: # rosbag2_tests/test/rosbag2_tests/test_rosbag2_record_end_to_end.cpp * Address merge conflicts Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
record_end_to_end_with_splitting_bagsize_split_is_at_least_specified_sizeintegration test which was a false negative all the time because the publisher was starting after terminating the recorder.