Update function prefix #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Garrido <pablogs9@gmail.com>
pablogs9
force-pushed
the
fix/message_support_duplication
branch
from
de93f11
to
0a155f5
Compare
clalancette
reviewed
May 21, 2021
There was a problem hiding this comment.
This idea seems totally reasonable to me. My only concern here is that this may trigger cpplint warnings since it adds a lot of text to function names. I guess we'll see when we run full CI, which I'll do next.
I would like to get another opinion from @sloretz as well.
|
CI:
|
pablogs9
added a commit
to micro-ROS/micro_ros_arduino
that referenced
this pull request
May 24, 2021
Remove when ros2/rosidl#596 is merged
pablogs9
added a commit
to micro-ROS/micro_ros_arduino
that referenced
this pull request
May 24, 2021
Remove when ros2/rosidl#596 is merged
mergify bot
pushed a commit
to micro-ROS/micro_ros_arduino
that referenced
this pull request
May 24, 2021
Remove when ros2/rosidl#596 is merged (cherry picked from commit cbddd26)
pablogs9
added a commit
to micro-ROS/micro_ros_arduino
that referenced
this pull request
May 24, 2021
Remove when ros2/rosidl#596 is merged (cherry picked from commit cbddd26) Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
pablogs9
added a commit
to micro-ROS/micro_ros_arduino
that referenced
this pull request
May 24, 2021
Workaround. Remove when ros2/rosidl#596 is merged
pablogs9
added a commit
to micro-ROS/micro_ros_arduino
that referenced
this pull request
May 24, 2021
Workaround. Remove when ros2/rosidl#596 is merged
mergify bot
pushed a commit
to micro-ROS/micro_ros_arduino
that referenced
this pull request
May 24, 2021
Workaround. Remove when ros2/rosidl#596 is merged (cherry picked from commit 4cb3bfd)
pablogs9
added a commit
to micro-ROS/micro_ros_arduino
that referenced
this pull request
May 24, 2021
Workaround. Remove when ros2/rosidl#596 is merged (cherry picked from commit 4cb3bfd) Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
|
Hello, @clalancette any update on this? |
|
@mergify backport galactic |
|
Thanks a lot, @clalancette. If you don't mind I have backported it to galactic. |
mergify bot
pushed a commit
that referenced
this pull request
Jun 15, 2021
Signed-off-by: Pablo Garrido <pablogs9@gmail.com> (cherry picked from commit 1d7b22f)
|
Command
Hey, I reacted but my real name is @Mergifyio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that this template will generate objects with same name if two packages have a .msg named equal.
This generate symbols named equal and in some cases, the linker will complain about this duplication.
In order to solve it, I propose to append also the package name that is guaranteed to be unique.