Use target output name for exporting typesupport library (backport #625) #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Signed-off-by: Jonathan Selling <jselling@neyarobotics.com> (cherry picked from commit e76ed13)
hidmic
force-pushed
the
mergify/bp/foxy/pr-625
branch
from
c948bc5
to
adda021
Compare
|
Full Foxy CI:
|
|
Foxy CI (build:
|
|
Hmm, windows has a lot of failures on both Foxy and Galactic. Here's a run without this PR to see if it's an existing issue. Foxy without this PR on windows (build: |
This was referenced Jul 13, 2022
|
Foxy CI re-run
|
|
Foxy Windows without this PR for comparison: Windows |
|
Any chance we could get this merged? I had to disable tests on some packages I support because of this issue. |
|
CI:
|
|
Windows for comparison: |
|
Retry Windows for comparison: |
|
Same flaky tests failed on Windows, getting this in |
quarkytale
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #625 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com