Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types for rosidl_adapter #828

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Types for rosidl_adapter #828

merged 6 commits into from
Nov 1, 2024

Conversation

InvincibleRMC
Copy link
Contributor

No description provided.

@InvincibleRMC
type for rosidl_adapter
32a4356 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC InvincibleRMC mentioned this pull request Oct 4, 2024
Open
@InvincibleRMC
re-run CI
fb13d0d 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
re-run CI
1a08266 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
use ament_cmake_mypy instead
e0d3f6e 
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
@InvincibleRMC
Merge branch 'ros2:rolling' into rosidl_adapter-types
7b7106f
@sloretz
Copy link
Contributor

sloretz commented Oct 31, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024

update

✅ Branch has been successfully updated

@sloretz
Copy link
Contributor

sloretz commented Oct 31, 2024 •
edited
Loading

Pulls: #828
Gist: https://gist.githubusercontent.com/sloretz/ac80e87a8cb9e792362c22d31750a888/raw/a0490aea3a605eeb4eb40b1ab21ce4335d15d80f/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_adapter
TEST args: --packages-above rosidl_adapter
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14757

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status (Infra issue, rebuild: Build Status)

@sloretz
Copy link
Contributor

sloretz commented Nov 1, 2024

Thank you for the PR!

@sloretz sloretz merged commit b6a890c into ros2:rolling Nov 1, 2024
4 checks passed
This was referenced Nov 6, 2024
Open
Open
@Crola1702
Copy link

Hey! There is a test regression in mypy happening with Windows Debug

See: #835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

@quarkytale quarkytale Awaiting requested review from quarkytale quarkytale is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@InvincibleRMC @sloretz @Crola1702