-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👨🌾 Fix NaN values bound numpy windows version #182
👨🌾 Fix NaN values bound numpy windows version #182
Conversation
Signed-off-by: Crola1702 <j.arroyo@uniandes.edu.co>
Signed-off-by: Crola1702 <j.arroyo@uniandes.edu.co>
Signed-off-by: Crola1702 <j.arroyo@uniandes.edu.co>
Signed-off-by: Crola1702 <j.arroyo@uniandes.edu.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do you think this approach is OK? @sloretz (tagging you as reviewer of the original PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable enough to me.
The Rpr job is currently expected to fail here, so we can ignore that and just use the CI results.
@mergify backport humble |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
@Mergifyio backport humble |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clalancette @sloretz this one too, what do you think?
* Replaced equal_nan for numpy<1.19 Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
* Allow NaN values to pass floating point bounds check. (#167) * Invert bounds check in order to permit floating point NaN values Signed-off-by: Øystein Sture <os@skarvtech.com> * Allow floating point numbers set to Inf to pass bounds check Signed-off-by: Øystein Sture <os@skarvtech.com> * Add float/double NaN/Inf tests Signed-off-by: Øystein Sture <os@skarvtech.com> * Increase precision of float32 bounds Signed-off-by: Øystein Sture <os@skarvtech.com> * Only perform float64 bounds check on non-compliant IEEE 754 systems Signed-off-by: Øystein Sture <os@skarvtech.com> * Disable bounds test for float64 on IEEE 754 compatible systems Signed-off-by: Øystein Sture <os@skarvtech.com> * Disable bounds test for float64 on IEEE 754 compatible systems Signed-off-by: Øystein Sture <os@skarvtech.com> * Resolve failing nan/inf test by comparing the same types Signed-off-by: Øystein Sture <os@skarvtech.com> * Change decode error mode to replace (#176) Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * Replace rosidl_cmake imports with rosidl_pycommon (#177) Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Delete trailing whitespace Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Split fail case array check tests into two Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Øystein Sture <os@skarvtech.com> Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Shane Loretz <sloretz@osrfoundation.org> * 👨🌾 Fix NaN values bound numpy windows version (#182) * Replaced equal_nan for numpy<1.19 Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> * Remove stray numpy import (#185) NumPy was being imported in the template code (not the template output) for apparently no reason. This was causing problems when cross-compiling, where NumPy is only available for the target platform. Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com> Signed-off-by: Øystein Sture <os@skarvtech.com> Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com> Co-authored-by: Øystein Sture <oysstu@users.noreply.github.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org> Co-authored-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com> Co-authored-by: Ben Wolsieffer <benwolsieffer@gmail.com>
🪰 BugFix
Issue
Reference build: Nightly Windows Debug
Log output:
Investigation
The proposed solution changes this test behavior to support both numpy <= 1.18 and >= 1.19.
Selected implementation: https://github.com/rossbar/numpy/blob/main/numpy/core/numeric.py#L2475
Windows build:![Build Status](https://camo.githubusercontent.com/1ba6da72e6bfbb9f7a0fcc4f314446d326d02bf48a3454356583652edb4de7c0/68747470733a2f2f63692e726f73322e6f72672f6a6f622f63695f77696e646f77732f31373633372f62616467652f69636f6e)
![Build Status](https://camo.githubusercontent.com/78a8d7a5f854e695e6d0d41139f2c46a65d05b350051f3c5dc10f146a2729d95/68747470733a2f2f63692e726f73322e6f72672f6a6f622f63695f6c696e75782d616172636836342f31313735322f62616467652f69636f6e)
![Build Status](https://camo.githubusercontent.com/0aadddcdd7ec03f15ec353b0c648beb2c07ab1aa1f388acb6020e0f89eb6b988/68747470733a2f2f63692e726f73322e6f72672f6a6f622f63695f6c696e75782f31373230392f62616467652f69636f6e)
Linux aarch64 build:
Linux build: