Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

border padding around main visualization window, not going away in fullscreen #1024

Closed
altineller opened this issue Jul 27, 2023 · 3 comments · Fixed by #1228
Closed

border padding around main visualization window, not going away in fullscreen #1024

altineller opened this issue Jul 27, 2023 · 3 comments · Fixed by #1228
Labels

Comments

@altineller
Copy link

Hello,

How can I make the border around main visualzation window go away? Or change its color if we cant make it go away.
When in full screen it apppears as a 8-9px white border.

I understand that there is no setting or customization for this, and I already have built rviz from source to get the default full screen launch going, and now I would like to remove the border or at least set it color to black.

Which part of code is responsible for this? I have been reading the source code, and could it be the border of a remote library or object?

Any ideas/help greatly appreciated.

Best Regards,
C.A.

@clalancette
Copy link
Contributor

Unfortunately, we don't have a great idea on how to do this. Likely this has something to do with the Qt settings or the theme, but I'm not sure. If you do figure something out, please feel free to update here or open a PR to improve things.

@altineller
Copy link
Author

@clalancette I think it has to do with te OgreRenderWindow.h, which is at ./ros/humble/opt/rviz_ogre_vendor/include/OGRE/OgreRenderWindow.h

@bochen87
Copy link
Contributor

bochen87 commented Jul 9, 2024

@clalancette I think it has to do with te OgreRenderWindow.h, which is at ./ros/humble/opt/rviz_ogre_vendor/include/OGRE/OgreRenderWindow.h

How did you solve this issue?

Edit: I found the issue, made a PR #1228 - Would be great if this could also be released into jazzy!

bochen87 added a commit to bochen87/rviz that referenced this issue Jul 9, 2024
bochen87 added a commit to bochen87/rviz that referenced this issue Jul 9, 2024
mergify bot pushed a commit that referenced this issue Jul 24, 2024
ahcorde pushed a commit that referenced this issue Jul 24, 2024
…en mode. Fixes #1024 (#1228) (#1250)

(cherry picked from commit 642b1a3)

Co-authored-by: Bo Chen <bo@enway.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants