Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ContentsMargins for RenderPanel to 0 to avoid borders in fullscreen mode #1228

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Set ContentsMargins for RenderPanel to 0 to avoid borders in fullscreen mode #1228

merged 2 commits into from
Jul 22, 2024

Conversation

bochen87
Copy link
Contributor

@bochen87 bochen87 commented Jul 9, 2024 •
edited
Loading

Fixes #1024

@bochen87 bochen87 requested a review from ahcorde as a code owner July 9, 2024 14:29
@bochen87 bochen87 changed the title Set Contentsmargin for RenderPanel to 0 to avoid borders in fullscreen mode Set ContentMargins for RenderPanel to 0 to avoid borders in fullscreen mode Jul 9, 2024
@bochen87 bochen87 changed the title Set ContentMargins for RenderPanel to 0 to avoid borders in fullscreen mode Set ContentsMargins for RenderPanel to 0 to avoid borders in fullscreen mode Jul 9, 2024
@bochen87 bochen87 mentioned this pull request Jul 9, 2024
Closed
@ahcorde
Copy link
Contributor

ahcorde commented Jul 19, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

ahcorde
ahcorde requested changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to merge with rolling ? then CI warnings should disappeared

@bochen87
Copy link
Contributor Author

Do you mind to merge with rolling ? then CI warnings should disappeared

sure, how do i do that?

@ahcorde
Copy link
Contributor

ahcorde commented Jul 22, 2024

You can type something like this

git fetch
git merge origin/rolling
git push origin rolling

@ahcorde
Copy link
Contributor

ahcorde commented Jul 22, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 642b1a3 into ros2:rolling Jul 22, 2024
2 checks passed
@bochen87
Copy link
Contributor Author

@ahcorde Can we also backport this to jazzy?

@ahcorde
Copy link
Contributor

ahcorde commented Jul 24, 2024

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link

mergify bot commented Jul 24, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 24, 2024
@bochen87 @mergify
Set ContentsMargins for RenderPanel to 0 to avoid borders in fullscre…
47df6ea 
…en mode. Fixes #1024 (#1228)

(cherry picked from commit 642b1a3)
@mergify mergify bot mentioned this pull request Jul 24, 2024
Merged
ahcorde pushed a commit that referenced this pull request Jul 24, 2024
@mergify @bochen87
Set ContentsMargins for RenderPanel to 0 to avoid borders in fullscre…
b158842 
…en mode. Fixes #1024 (#1228) (#1250)

(cherry picked from commit 642b1a3)

Co-authored-by: Bo Chen <bo@enway.ai>
@bochen87
Copy link
Contributor Author

https://github.com/Mergifyio backport jazzy

Thanks for backporting! Is it possible to tag a new version so it get's released in the next cycle?

@ahcorde
Copy link
Contributor

ahcorde commented Aug 19, 2024

https://github.com/Mergifyio backport jazzy

Thanks for backporting! Is it possible to tag a new version so it get's released in the next cycle?

ros/rosdistro#42481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde requested changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

border padding around main visualization window, not going away in fullscreen
2 participants
@bochen87 @ahcorde