-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add profile for lifecycle nodes #146
add profile for lifecycle nodes #146
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
With development of #147, it would make sense create like |
I'm having trouble wrapping my head around how much this turns into. I feel like it could be a lot, though, so I tend to agree that it should be held in a dedicated place. |
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Hosting in a separate package rather than in sros2 itself seems sensible 👍
I don't have a strong preference, we can either merge this now or wait for #147 to land and then target this at the new package. |
@mjcarroll @jacobperron is it possible to merge this ? I'm happy to iterate once #147 is picked up |
@mikaelarguedas Just to clarify, what is the intended purpose for the new profile? It appears in the |
The goal is to have all the common ROS primitive policies stored at the same place. This way they can be easily copied and reused. But they won't be installed until the work to actually install and register policies is complete (see #147). The fact that the lifecycle ones are not on any "official" branch makes it harder to track changes such as b10a7e9 The value of such policies is to simplify policy files such as ros-swg/turtlebot3_demo@2d394cb#diff-d989d1536b8a5fbbdf2e4f029676fc6b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for a separate package in the future.
I can merge this now so it's available for when this happens.
Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com
What would be a good place for storing common policy profiles in the future? Should they be in the sros2 package and installed by it? or would a separate package be more appropriate?
cc @ruffsl @kyrofa