Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add profile for lifecycle nodes #146

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

mikaelarguedas
Copy link
Member

Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com

What would be a good place for storing common policy profiles in the future? Should they be in the sros2 package and installed by it? or would a separate package be more appropriate?

cc @ruffsl @kyrofa

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@ruffsl
Copy link
Member

ruffsl commented Aug 1, 2019

With development of #147, it would make sense create like sros2_common_something. I'm not sure what to call it as it could be used to hold policies, profiles, or profiles snippets. But the gist of housing common ones in a separate package seems good.

@kyrofa
Copy link
Member

kyrofa commented Aug 1, 2019

I'm having trouble wrapping my head around how much this turns into. I feel like it could be a lot, though, so I tend to agree that it should be held in a dedicated place. sros2_common_assets?

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas
Copy link
Member Author

With development of #147, it would make sense create like sros2_common_something. I'm not sure what to call it as it could be used to hold policies, profiles, or profiles snippets

Hosting in a separate package rather than in sros2 itself seems sensible 👍

I'm having trouble wrapping my head around how much this turns into. I feel like it could be a lot, though, so I tend to agree that it should be held in a dedicated place. sros2_common_assets?

sros2_common_assets sounds good to me. I would also be fine with sros2_common_policies as I see profiles and profiles snippets as a subset of policies (similar to how docker snippets are hosted in the docker_templates repository)


I don't have a strong preference, we can either merge this now or wait for #147 to land and then target this at the new package.

@mikaelarguedas
Copy link
Member Author

@mjcarroll @jacobperron is it possible to merge this ? I'm happy to iterate once #147 is picked up

@jacobperron
Copy link
Member

@mikaelarguedas Just to clarify, what is the intended purpose for the new profile? It appears in the test directory and is not used by any tests nor is it installed.

@mikaelarguedas
Copy link
Member Author

The goal is to have all the common ROS primitive policies stored at the same place. This way they can be easily copied and reused. But they won't be installed until the work to actually install and register policies is complete (see #147).

The fact that the lifecycle ones are not on any "official" branch makes it harder to track changes such as b10a7e9

The value of such policies is to simplify policy files such as ros-swg/turtlebot3_demo@2d394cb#diff-d989d1536b8a5fbbdf2e4f029676fc6b

Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for a separate package in the future.
I can merge this now so it's available for when this happens.

@jacobperron jacobperron merged commit d7df87a into ros2:master Oct 21, 2019
@mikaelarguedas mikaelarguedas deleted the lifecycle_node_policy branch October 21, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants