[WIP] Register common policies with the ament index #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruffsl
reviewed
Aug 1, 2019
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <profile xmlns:xi="http://www.w3.org/2003/XInclude"> | |||
| <sros2_policy package="sros2_common_policies" policy="node/logging.xml" /> | |||
There was a problem hiding this comment.
I think I'd prefer that assets inside the same package keep with using the conventional XML xinclude for importation, so that a preprocessor to recursively expand <sros2_policy> tags would not be a requirement in reusing assets in the sros2 common package.
Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll
force-pushed
the
mjcarroll/register_policies
branch
from
0422be1
to
3d46d89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.