Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crystal-backport] Backport #95 to Crystal #97

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Conversation

mjcarroll
Copy link
Member

@mjcarroll mjcarroll commented Mar 12, 2019

Backport patch from #95 into Crystal.

* remove unecessary ament_cmake_test

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

* remove ament_lint_auto dependency

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

* add back ament_cmake_test with comment

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mjcarroll mjcarroll self-assigned this Mar 12, 2019
@mjcarroll mjcarroll added the in review Waiting for review (Kanban column) label Mar 12, 2019
@nuclearsandwich

This comment has been minimized.

@nuclearsandwich
Copy link
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS (crystal infra) Build Status
  • Windows Build Status

@mjcarroll
Copy link
Member Author

The Windows failure is a known CI failure, should be addressed via: ros2/ci#261

@mjcarroll mjcarroll merged commit e0a7104 into crystal Mar 12, 2019
@mjcarroll mjcarroll deleted the backport_95_crystal branch March 12, 2019 21:21
@mjcarroll mjcarroll removed the in review Waiting for review (Kanban column) label Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants