Account for potential target namespace when finding cmake module...

[jacobperron]

for tinyxml2.

Resolves ros2/build_farmer#156

[wjwwood]

Makes sense to me.

[jacobperron]

Looks like the namespace is not required when linking.

[jacobperron]

Test on CI machine with latest tinyxml2 release:

Requires ros2/Fast-RTPS (find_tinyxml2_update).

[jacobperron]

Regular CI (includes MacOS with older tinyxml2 release to test backwards compatibility):

• Linux
• Linux-aarch64
• macOS
• Windows

[jacobperron]

Take 2:

• Linux
• Linux-aarch64
• macOS
• Windows

[jacobperron]

Take 3:

• Linux
• Linux-aarch64
• macOS
• Windows

[jacobperron]

The test CI job made it past the tinyxml related errors and is stuck on an unrelated error.

---

Rebuild Windows: 🤞

[Karsten1987]

I contributed to this patch, but +1 because it also solves the problems locally on my osx.

changes

[Karsten1987]

rebuilding on my machine seems to work. so +1

[jacobperron]

• Linux
• Linux-aarch64
• macOS
• Windows

[nuclearsandwich]

03:57:23 -- Found fastrtps_cmake_module: 0.6.0 (/home/rosbuild/ci_scripts/ws/install/fastrtps_cmake_module/share/fastrtps_cmake_module/cmake)
03:57:23 CMake Error at /home/rosbuild/ci_scripts/ws/install/fastrtps/share/fastrtps/cmake/fastrtps-config.cmake:50 (find_package):
03:57:23   By not providing "FindTinyXML2.cmake" in CMAKE_MODULE_PATH this project has
03:57:23   asked CMake to find a package configuration file provided by "TinyXML2",
03:57:23   but CMake did not find one.
03:57:23 
03:57:23   Could not find a package configuration file provided by "TinyXML2" with any
03:57:23   of the following names:
03:57:23 
03:57:23     TinyXML2Config.cmake
03:57:23     tinyxml2-config.cmake
03:57:23 
03:57:23   Add the installation prefix of "TinyXML2" to CMAKE_PREFIX_PATH or set
03:57:23   "TinyXML2_DIR" to a directory containing one of the above files.  If
03:57:23   "TinyXML2" provides a separate development package or SDK, be sure it has
03:57:23   been installed.
03:57:23 Call Stack (most recent call first):
03:57:23   CMakeLists.txt:38 (find_package)

[jacobperron]

After update to eProsima/Fast-DDS#349:

• Linux
• Linux-aarch64
• macOS
• Windows

[mjcarroll]

Looks like network issues for both of these, rebuilding.

• macOS
• Windows

[nuclearsandwich]

The VCS import failed again. When I try to import that repos file locally I get

=== src/ros2/Fast-RTPS (git) ===
Could not checkout ref 'find_tinyxml2_update': error: pathspec 'find_tinyxml2_update' did not match any file(s) known to git.

Since Fast-RTPS has merged eProsima/Fast-DDS#349 here is the same again with just this branch.

🍎
🎐 (queued)

[jacobperron]

Aaand the updated 🍎

[nuclearsandwich]

Again and again... 🍎

This time qt is linked so qmake is on PATH

[nuclearsandwich]

The CI failures above are caused by a rash of infrastructure related troubles and a recent issue with Windows that is not introduced by this change.

Build on our current MacOS configuration is passing:
The updated MacOS configuration where this issue was first discovered is now able to build packages dependent on TinyXML2 but has issues with other upgraded packages
Windows test failures are unrelated (also failures are causing builds to run very long)

I am proposing that given the reviews received on this change and the CI coverage as available, that this PR be considered merge-able.