Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate methods that require tinyxml #12

Merged
merged 1 commit into from
May 19, 2020
Merged

Deprecate methods that require tinyxml #12

merged 1 commit into from
May 19, 2020

Conversation

rotu
Copy link

@rotu rotu commented May 1, 2020

For #11 to land in Foxy+1

@rotu
Copy link
Author

rotu commented May 1, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link

sloretz commented May 1, 2020 •
edited
Loading

@rotu restarted CI testing only urdf and the packages above. We're a bit tight on CI capacity right now; so please make sure to use build and test args to limit the time a job takes when possible.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status <- Got scheduled on mini1, but that agent needs another dependency installed. Will restart this one in a bit
    • rerun: Build Status
      • rererun Build Status
  • Windows Build Status

@rotu
Copy link
Author

rotu commented May 1, 2020

  • Linux Build Status

CI run shows deprecation warnings, which are addressed by pending PRs: ros2/kdl_parser#7 and ros2/rviz#531

@rotu
Copy link
Author

rotu commented May 7, 2020

@sloretz What's the status on this?

@clalancette clalancette mentioned this pull request May 14, 2020
Merged
clalancette
clalancette approved these changes May 14, 2020
View reviewed changes
Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me assuming we can get green CI along with the rest of the PRs.

@clalancette
Copy link

@ros-pull-request-builder retest this please

@clalancette clalancette mentioned this pull request May 15, 2020
Merged
@clalancette
Copy link

For future reference, CI for this was in ros2/rviz#531 (comment)

@clalancette clalancette merged commit d48b94e into ros2:ros2 May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@clalancette clalancette clalancette approved these changes

Assignees

@clalancette clalancette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rotu @sloretz @clalancette @jacobperron