Fix different png images getting same hash.#63
Merged
ole1986 merged 1 commit intorospdf:masterfrom May 2, 2017
Merged
Conversation
If png images with the same size but different content using only black on a transparent background the first included image replaces all subsequent images even if different since they get the same hash because idata string is the same. Creating the hash from the actual content of the file instead of idata fixes this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If png images with the same size but different
content using only black on a transparent
background the first included image replaces all
subsequent images even if different since they get
the same hash because idata string is the same.
Creating the hash from the actual content of the
file instead of idata fixes this issue.