Skip to content

Little fix while generating some PDF#92

Merged
ole1986 merged 1 commit intorospdf:masterfrom
shawe:patch-2
Jan 2, 2018
Merged

Little fix while generating some PDF#92
ole1986 merged 1 commit intorospdf:masterfrom
shawe:patch-2

Conversation

@shawe
Copy link
Copy Markdown
Contributor

@shawe shawe commented Jan 1, 2018

This fixes some issues when generating some PDF.

  • L672: $num is defined in PHPDoc has int, but default value was an empty string. Without this change, pagination is always 0 of 0 when this parameter is not specified by default.
  • L1544: An empty string is not array or countable. Without this change, it was outputing warning messages like this: Warning: count(): Parameter must be an array or an object that implements Countable in vendor/rospdf/pdf-php/src/Cezpdf.php on line 1544. Maybe is a better solution replace '$fillColor && ' by '!empty($fillColor) && '.

@ole1986 ole1986 merged commit 154700d into rospdf:master Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants