Bugfix/ca 17 deleted files persist in analysis context#121
Merged
Bugfix/ca 17 deleted files persist in analysis context#121
Conversation
- Introduced ProjectRulesConfig to manage custom review rules for projects. - Added RuleType enum to define rule types (ENFORCE, SUPPRESS). - Implemented UpdateProjectRulesRequest DTO for updating rules. - Enhanced ProjectDTO to include project rules configuration. - Updated ProjectService to handle retrieval and updating of project rules. - Integrated project rules into AI client services for Bitbucket, GitHub, and GitLab. - Added endpoints in ProjectController for fetching and updating project rules. - Updated Python inference orchestrator to format and utilize project rules in review stages. - Added configuration property for maximum custom rules per project. - Updated application properties sample to include project rules configuration.
- Updated GitHubAiClientService and GitLabAiClientService to include handling of deleted files during analysis requests. - Modified AiAnalysisRequest DTO to add a new field for deleted files. - Enhanced context formatting in RAG to filter out chunks from deleted files, ensuring stale references are not flagged. - Updated prompt builder to include context about deleted files in the generated prompts for better LLM understanding. - Improved logging to track the number of skipped chunks from deleted files during analysis.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for handling deleted files and custom project review rules in the AI analysis request flow, and includes several code cleanups and documentation improvements. The main changes are the introduction of new fields and methods to track deleted files and project-specific rules, as well as the extraction logic for deleted files from diffs.
AI Analysis Request Enhancements:
deletedFilesandprojectRulesfields toAiAnalysisRequestImpl, including their getters, builder methods, and integration throughout the class. This allows the system to track files deleted in a pull request and to pass custom project review rules as part of the AI analysis request. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Diff Parsing Utilities:
extractDeletedFilesmethod inDiffParserto identify deleted files from a unified diff, supporting more accurate context enrichment and LLM prompts.Configuration:
application.properties.sample.Formatting and Documentation:
Frontend Submodule Update: