Skip to content

Bugfix/ca 17 deleted files persist in analysis context#121

Merged
rostilos merged 2 commits into1.4.1-rcfrom
bugfix/CA-17-deleted-files-persist-in-analysis-context
Feb 17, 2026
Merged

Bugfix/ca 17 deleted files persist in analysis context#121
rostilos merged 2 commits into1.4.1-rcfrom
bugfix/CA-17-deleted-files-persist-in-analysis-context

Conversation

@rostilos
Copy link
Owner

@rostilos rostilos commented Feb 17, 2026

This pull request adds support for handling deleted files and custom project review rules in the AI analysis request flow, and includes several code cleanups and documentation improvements. The main changes are the introduction of new fields and methods to track deleted files and project-specific rules, as well as the extraction logic for deleted files from diffs.

AI Analysis Request Enhancements:

  • Added deletedFiles and projectRules fields to AiAnalysisRequestImpl, including their getters, builder methods, and integration throughout the class. This allows the system to track files deleted in a pull request and to pass custom project review rules as part of the AI analysis request. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Diff Parsing Utilities:

  • Implemented extractDeletedFiles method in DiffParser to identify deleted files from a unified diff, supporting more accurate context enrichment and LLM prompts.

Configuration:

  • Added a configuration property placeholder for the maximum number of custom project rules per project in application.properties.sample.

Formatting and Documentation:

  • Improved code formatting and expanded documentation for methods and classes, especially around diff parsing and issue deduplication, for better readability and maintainability. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Frontend Submodule Update:

  • Updated the frontend submodule to a newer commit, likely to keep UI changes in sync with backend updates.

- Introduced ProjectRulesConfig to manage custom review rules for projects.
- Added RuleType enum to define rule types (ENFORCE, SUPPRESS).
- Implemented UpdateProjectRulesRequest DTO for updating rules.
- Enhanced ProjectDTO to include project rules configuration.
- Updated ProjectService to handle retrieval and updating of project rules.
- Integrated project rules into AI client services for Bitbucket, GitHub, and GitLab.
- Added endpoints in ProjectController for fetching and updating project rules.
- Updated Python inference orchestrator to format and utilize project rules in review stages.
- Added configuration property for maximum custom rules per project.
- Updated application properties sample to include project rules configuration.
- Updated GitHubAiClientService and GitLabAiClientService to include handling of deleted files during analysis requests.
- Modified AiAnalysisRequest DTO to add a new field for deleted files.
- Enhanced context formatting in RAG to filter out chunks from deleted files, ensuring stale references are not flagged.
- Updated prompt builder to include context about deleted files in the generated prompts for better LLM understanding.
- Improved logging to track the number of skipped chunks from deleted files during analysis.
@coderabbitai
Copy link

coderabbitai bot commented Feb 17, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/CA-17-deleted-files-persist-in-analysis-context

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rostilos rostilos merged commit 54b5c33 into 1.4.1-rc Feb 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant