Skip to content

Conversation

@rostilos
Copy link
Owner

No description provided.

…n McpTools. Implement integration tests for webhook-triggered analysis and incremental analysis. Update OAuthCallbackController to streamline redirect URLs. Add TestSecurityConfig for enhanced test security configuration.
…remental update failures. Update related services and DTOs to support new functionality. Enhance VCS integration with additional event handling.
…dling; add settings page and secure auth token generation
@codecrow-local
Copy link

⚠️ Code Analysis Results

Summary

Internal analysis APIs are exposed without authentication and can be called by anyone knowing a projectId/analysisId, exposing sensitive analysis data.

Issues Overview

Severity Count
🔴 High 1 Critical issues requiring immediate attention

Detailed Issues

🔴 High Severity Issues

Id on Platform: 431

File: .../internal/InternalAnalysisController.java:31

Issue: All endpoints under /api/internal/analysis are exposed via WebSecurityConfig (requestMatchers("/api/internal/**").permitAll()) and the controller only checks projectId/analysisId parameters. An unauthenticated client can enumerate IDs and retrieve any project’s code analysis data, leaking sensitive information.

Suggested Fix:

Require the internal shared secret header (e.g., X-Internal-Secret) on every handler and reject requests when it does not match codecrow.internal.api.secret.

View Issue Details


Files Affected

  • .../internal/InternalAnalysisController.java: 1 issue

Analysis completed on 2025-12-24 17:03:40 | View Full Report | Pull Request

@rostilos rostilos closed this Dec 24, 2025
@coderabbitai coderabbitai bot mentioned this pull request Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants