chore: 💄 add brand.yml
#51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwjohnst86
requested changes
May 23, 2025
| from: markdown+emoji | ||
| theme: | ||
| - brand | ||
| - yeti |
Member
There was a problem hiding this comment.
Is this still necessary? Or it overlaps anything missing from brand?
Member
Author
There was a problem hiding this comment.
This is where you get the primary colour from. Maybe/probably also other things. I just assumed you would like to keep it. If it's only the colour, I can just add it to the brand and remove yeti?
| book: | ||
| title: Testing | ||
| author: Luke W. Johnston | ||
| author: Luke W. Johnston and Signe Kirk Brødbæk |
Member
There was a problem hiding this comment.
Ha, is this this discreet thing? 😝
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
lwjohnst86
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a
brand.ymland adds some extra examples to test the scss defauls and rules from the brand.It also does something else very discreetly 🙈
This PR needs an in-depth review.
Checklist
just run-all