Simplify resource attribute handling and reduce clones#281
Merged
Conversation
Signed-off-by: Mike Heffner <mikeh@fesnel.com>
Signed-off-by: Mike Heffner <mikeh@fesnel.com>
Signed-off-by: Mike Heffner <mikeh@fesnel.com>
rjenkins
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts the mutable resource method from the attribute building, allowing us to simplify the base code.
After this, we reduce the number of clones required here. From claude's summary, the following were reduced:
Vec<KeyValue>structure itselfmap.values().cloned()Stringkeys(N items in payload, M resource attributes)