Rewrite the GLSL lexer as not a subclass of C#2249
Merged
Conversation
jneen
changed the title
jneen
force-pushed
the
lexer.glsl-rework
branch
from
f3e58c9 to
e253632
Compare
jneen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GLSL lexer (previously
Glsl) was written as a subset of C, which is incorrect - GLSL is its own language with its own syntax, which is only superficially similar to C.Luckily it's a fairly simple language with a straightforward spec, albeit with a large ever-growing list of types and builtins. I've gone ahead and rewritten it, along with a lazy-loaded and doc-generated builtins script.