Skip to content

install.sh complaining about missing directory#222

Closed
probabble wants to merge 0 commit intoroundware:developfrom
probabble:develop
Closed

install.sh complaining about missing directory#222
probabble wants to merge 0 commit intoroundware:developfrom
probabble:develop

Conversation

@probabble
Copy link
Copy Markdown
Contributor

No description provided.

@hburgund
Copy link
Copy Markdown
Member

Ha! We discovered this issue a few days ago, but you beat us to the punch with committing the fix. Thanks for the contribution.

I believe there is one additional line of code needed to fully remedy the issue, resulting in this block:

mkdir $WWW_PATH/settings
cp $SOURCE_PATH/files/var-www-roundware-settings.py $WWW_PATH/settings/roundware_production.py
chown $USERNAME:$USERNAME -R $WWW_PATH/settings

If you could give this a corroborative test and if all works on a fresh vagrant build, then just update your pull request and I'm merge it.
Oh, and welcome to the project(!)

@13rac1
Copy link
Copy Markdown
Member

13rac1 commented Feb 22, 2015

Please update(rebase) the commit message with why/what the purpose of the change is.

Thanks for your help!

@probabble probabble closed this Feb 22, 2015
@probabble probabble reopened this Feb 22, 2015
@probabble
Copy link
Copy Markdown
Contributor Author

Sorry about the initial commit message - will be more precise in the future... Vagrant builds without errors.

Not sure if you use the Django test suite, but if I login to the VM and do manage.py test I get an error:

/var/www/roundware/source/roundware/manage.py test
Creating test database for alias 'default'...
Got an error creating the test database: (1044, "Access denied for user 'round'@'localhost' to database 'test_roundware'")
Type 'yes' if you would like to try deleting the test database 'test_roundware', or 'no' to cancel: yes
Destroying old test database 'default'...
Got an error recreating the test database: (1044, "Access denied for user 'round'@'localhost' to database 'test_roundware'")

Can make a separate issue for that or ignore it.

Do you all have a talk page / roadmap where I can get an idea of your current goals? I'm really interested in this project - want to use it for an upcoming art installation and hopefully contribute :)

@13rac1
Copy link
Copy Markdown
Member

13rac1 commented Mar 9, 2015

@probabble Many of the todos are listed here: enhancement We don't have a roadmap document yet. There's still a lot to do, as you can see. @hburgund is working to finalize the contributor agreement.

Run tests with:

cd scripts
./tests.sh

@13rac1
Copy link
Copy Markdown
Member

13rac1 commented Mar 11, 2015

@probabble Please rebase this branch into a single commit:

git rebase -i 44c99ad2fab91f38b52f9023e5578eb3dd92b27b

Comment thread install.sh Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to the -p in the mkdir command so that running install.sh a second time will not error.

Comment thread install.sh Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... this line is redundant due to:

chown $USERNAME:$USERNAME -R $WWW_PATH

@13rac1
Copy link
Copy Markdown
Member

13rac1 commented Mar 12, 2015

@probabble Do you mind if I just make a separate commit for the one line change required to fix this issue? I'll set you as commit author.

@probabble
Copy link
Copy Markdown
Contributor Author

Yes, @eosrei, please do. I'm apparently not skilled at rewriting history 🌴

@13rac1
Copy link
Copy Markdown
Member

13rac1 commented Mar 12, 2015

This issue will be corrected when #217 is merged.

@probabble
Copy link
Copy Markdown
Contributor Author

👍
super.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants