install.sh complaining about missing directory#222
install.sh complaining about missing directory#222probabble wants to merge 0 commit intoroundware:developfrom
Conversation
|
Ha! We discovered this issue a few days ago, but you beat us to the punch with committing the fix. Thanks for the contribution. I believe there is one additional line of code needed to fully remedy the issue, resulting in this block: If you could give this a corroborative test and if all works on a fresh vagrant build, then just update your pull request and I'm merge it. |
|
Please update(rebase) the commit message with why/what the purpose of the change is. Thanks for your help! |
|
Sorry about the initial commit message - will be more precise in the future... Vagrant builds without errors. Not sure if you use the Django test suite, but if I login to the VM and do Can make a separate issue for that or ignore it. Do you all have a talk page / roadmap where I can get an idea of your current goals? I'm really interested in this project - want to use it for an upcoming art installation and hopefully contribute :) |
|
@probabble Many of the todos are listed here: enhancement We don't have a roadmap document yet. There's still a lot to do, as you can see. @hburgund is working to finalize the contributor agreement. Run tests with: |
|
@probabble Please rebase this branch into a single commit: |
There was a problem hiding this comment.
We need to the -p in the mkdir command so that running install.sh a second time will not error.
There was a problem hiding this comment.
Hmm... this line is redundant due to:
Line 57 in c0d5cf6
|
@probabble Do you mind if I just make a separate commit for the one line change required to fix this issue? I'll set you as commit author. |
|
Yes, @eosrei, please do. I'm apparently not skilled at rewriting history 🌴 |
|
This issue will be corrected when #217 is merged. |
|
👍 |
No description provided.