fix(claude translator): guard tool schema properties #257
Conversation
Summary of ChangesHello @lollipopkit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a fix for the Claude translator by enhancing the validation and normalization of tool parameter schemas. A new function, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where a tool schema without a properties field would cause an error. The fix introduces a normalizeToolParameters function to ensure that any object-type tool schema has at least an empty properties map.
My review focuses on the new normalizeToolParameters function. While the current implementation fixes the reported issue, it has some edge cases that could lead to other problems. I've provided a suggestion to make the function more robust by handling non-object JSON inputs and schemas with types other than object.
| raw = strings.TrimSpace(raw) | ||
| if raw == "" || raw == "null" || !gjson.Valid(raw) { | ||
| return `{"type":"object","properties":{}}` | ||
| } | ||
| schema := raw | ||
| result := gjson.Parse(raw) | ||
| schemaType := result.Get("type").String() | ||
| if schemaType == "" { | ||
| schema, _ = sjson.Set(schema, "type", "object") | ||
| schemaType = "object" | ||
| } | ||
| if schemaType == "object" && !result.Get("properties").Exists() { | ||
| schema, _ = sjson.SetRaw(schema, "properties", `{}`) | ||
| } | ||
| return schema |
There was a problem hiding this comment.
The implementation of normalizeToolParameters can be made more robust. There are two potential issues:
- It doesn't correctly handle valid JSON that is not an object (e.g.,
[],"a string"). This can cause silent failures insjsonand pass an invalid schema downstream. - It doesn't handle schemas that have a
typeother than"object"(e.g.,"type": "string"). These are passed through as-is and will likely cause errors in the target API, which expects an object withproperties.
The suggested change refactors the function to address both issues by ensuring the schema is a JSON object and has the correct structure before returning.
raw = strings.TrimSpace(raw)
result := gjson.Parse(raw)
schemaType := result.Get("type").String()
if !result.IsObject() || (schemaType != "" && schemaType != "object") {
return `{"type":"object","properties":{}}`
}
schema := raw
if schemaType == "" {
schema, _ = sjson.Set(schema, "type", "object")
}
if !result.Get("properties").Exists() {
schema, _ = sjson.SetRaw(schema, "properties", `{}`)
}
return schema
fix(claude translator): guard tool schema properties
2 participants
Fixed：
