Skip to content

Conversation

@hkfires
Copy link
Collaborator

@hkfires hkfires commented Dec 3, 2025

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @hkfires, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on API refactoring by eliminating outdated and redundant endpoints related to generative-language-api-key management. It also enhances the clarity and efficiency of configuration retrieval by consolidating the config.yaml endpoint to use a single, direct method for fetching the raw YAML content, thereby reducing code duplication and improving maintainability.

Highlights

  • Removal of Legacy API Endpoints: The /generative-language-api-key endpoints and all associated helper functions (e.g., sanitizeStringSlice, geminiKeyStringsFromConfig, applyLegacyKeys) have been completely removed from the API.
  • Refactored Config YAML Retrieval: The logic for retrieving the config.yaml file has been streamlined. A previously redundant GetConfigYAML function that re-encoded YAML was removed, and the GetConfigFile function (which returns the raw YAML bytes) was renamed to GetConfigYAML to serve the /config.yaml route, ensuring a single, clear method for this operation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great refactoring that improves the API by removing legacy endpoints and cleaning up duplicated code. The removal of the generative-language-api-key endpoints and their associated logic in config_lists.go and server.go simplifies the codebase. Additionally, replacing the inefficient GetConfigYAML implementation with a direct file-serving approach (previously named GetConfigFile) in config_basic.go is a good performance and correctness improvement, as it preserves YAML formatting and comments. The changes are well-executed and align perfectly with the goal of the pull request.

@luispater luispater merged commit 6efba3d into dev Dec 3, 2025
1 check passed
@luispater luispater deleted the api branch December 3, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants