-
-
Notifications
You must be signed in to change notification settings - Fork 364
fix(gemini): normalize model listing output #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @hkfires, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the consistency and clarity of model listings, particularly for Gemini and OpenAI compatibility models. It standardizes model display names, introduces canonical naming for internal model configurations, and normalizes the API output for Gemini models to ensure a predictable and well-structured response, improving the overall model management and discovery experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request focuses on normalizing the model listing output, particularly for Gemini models. The changes include updating OpenAI model definitions to version 5.1, adding a canonical Name field to AntigravityModelConfig to standardize model names, and updating the Gemini API handler to ensure model names are correctly formatted in the response. Additionally, there's a fix to make the DisplayName for OpenAI-compatibility models consistent with their ID. The changes are logical and well-aligned with the PR's goal. I have one suggestion to improve consistency in the new model definitions.
| "gemini-claude-sonnet-4-5-thinking": {Thinking: &ThinkingSupport{Min: 1024, Max: 200000, ZeroAllowed: false, DynamicAllowed: true}, MaxCompletionTokens: 64000}, | ||
| "gemini-claude-opus-4-5-thinking": {Thinking: &ThinkingSupport{Min: 1024, Max: 200000, ZeroAllowed: false, DynamicAllowed: true}, MaxCompletionTokens: 64000}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new Name field has been added to AntigravityModelConfig and is populated for most models in GetAntigravityModelConfig. However, gemini-claude-sonnet-4-5-thinking and gemini-claude-opus-4-5-thinking are missing this field. While the code in antigravity_executor.go has a fallback, for consistency and to avoid relying on fallbacks, it would be better to add the Name field to these model configurations as well.
| "gemini-claude-sonnet-4-5-thinking": {Thinking: &ThinkingSupport{Min: 1024, Max: 200000, ZeroAllowed: false, DynamicAllowed: true}, MaxCompletionTokens: 64000}, | |
| "gemini-claude-opus-4-5-thinking": {Thinking: &ThinkingSupport{Min: 1024, Max: 200000, ZeroAllowed: false, DynamicAllowed: true}, MaxCompletionTokens: 64000}, | |
| "gemini-claude-sonnet-4-5-thinking": {Thinking: &ThinkingSupport{Min: 1024, Max: 200000, ZeroAllowed: false, DynamicAllowed: true}, MaxCompletionTokens: 64000, Name: "models/gemini-claude-sonnet-4-5-thinking"}, | |
| "gemini-claude-opus-4-5-thinking": {Thinking: &ThinkingSupport{Min: 1024, Max: 200000, ZeroAllowed: false, DynamicAllowed: true}, MaxCompletionTokens: 64000, Name: "models/gemini-claude-opus-4-5-thinking"}, |
No description provided.